linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: "Linux kernel regression tracking \(Thorsten Leemhuis\)" 
	<regressions@leemhuis.info>
Cc: Bert Karwatzki <spasswolf@web.de>,
	Linux regressions mailing list <regressions@lists.linux.dev>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Felix Fietkau <nbd@nbd.name>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6.2-rc3] wifi: mt76: fix dma error
Date: Fri, 13 Jan 2023 18:15:31 +0200	[thread overview]
Message-ID: <87fscebecc.fsf@kernel.org> (raw)
In-Reply-To: <b8a3fa69-a4c2-51b5-d193-d4d933cf6627@leemhuis.info> (Linux kernel regression tracking's message of "Wed, 11 Jan 2023 08:54:12 +0100")

"Linux kernel regression tracking (Thorsten Leemhuis)"
<regressions@leemhuis.info> writes:

> [CCing Felix]
>
> On 10.01.23 23:39, Bert Karwatzki wrote:
>> Since linux-6.2-rc1 the mediatek mt76 wlan driver suffers from problems
>> https://bugzilla.kernel.org/show_bug.cgi?id=216901. I bisected this to
>> commit cd372b8c99c5a5cf6a464acebb7e4a79af7ec8ae and noticed that the
>> 
>> 	if (txwi) {
>> 		q->entry[q->head].txwi = DMA_DUMMY_DATA;
>> 		q->entry[q->head].skip_buf0 = true;
>> 	}
>> 
>> part is moved from the beginning of mt76_dma_add_buf to the
>> inside of the for loop. But q->head is modified at the beginning of
>> this loop.
>
> Thx for your patch. TWIMC, a earlier (and tested) patch to address that
> regression can afaics be found here:
>
> https://lore.kernel.org/lkml/3cb53fbd-0bee-22f9-bba2-6ac4a87db521@nbd.name/
>
> Makes me wonder: Felix, btw, did you ever properly submit that patch for
> inclusion? Where? I can't find it with lore. :-/ Or will it be addressed
> by a different patch?

The patch is now in my queue:

https://patchwork.kernel.org/project/linux-wireless/patch/20230113105848.34642-3-nbd@nbd.name/

> /me really hopes we can get this resolved this week before rc4 ships, as
> it seems this regressions bothers quite a few people

If all goes well this should make it to v6.2-rc5.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      reply	other threads:[~2023-01-13 16:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10 22:39 [PATCH 6.2-rc3] wifi: mt76: fix dma error Bert Karwatzki
2023-01-11  7:54 ` Linux kernel regression tracking (Thorsten Leemhuis)
2023-01-13 16:15   ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fscebecc.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=spasswolf@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).