From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB776C3F6B0 for ; Thu, 28 Jul 2022 09:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235626AbiG1Jj7 (ORCPT ); Thu, 28 Jul 2022 05:39:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234722AbiG1Jj6 (ORCPT ); Thu, 28 Jul 2022 05:39:58 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B92156583D for ; Thu, 28 Jul 2022 02:39:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E842ECE2454 for ; Thu, 28 Jul 2022 09:39:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E5AAC433D6; Thu, 28 Jul 2022 09:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659001194; bh=qXUVGAu6hglYXNpvMNBsrp9DHVGY7weJHUgB4TfEgXs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PAfGQozZUH1RF44yXPAZK+8nc+YtOf8tgZedZnvnItWxP77ZSca4afB9odIMSmLLH zyVzTWrz2qSzlRuPU/n6DJWn7BGNnXhL9ZVBWectwEUJBBfYAEo0ShuvGLRYpU6wpr p+Jtp3y0cqi9ps+IB5nAJ3ihBbdNmS23A+OO/8vG5FD6o7/82qNZbWmwRJeLagQId2 I5+UCbZAaK9OQ4S5qQDECOyeYRkv9nwRh6Act2ZYC/FkkQ6EX+uTc/KDRfJdZwvrSD 7nlExQ5trq5lV87giNZPh9ACO/xVpPOPTQ7OUPM5jHwC/OKk71cVrkJK/egXNu2opK kvFA1LuNU0E7g== From: Kalle Valo To: aspriel@gmail.com Cc: arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH 7/7] brcmfmac: introduce BRCMFMAC exported symbols namespace References: <20220613091915.18884-1-arend.vanspriel@broadcom.com> Date: Thu, 28 Jul 2022 12:39:51 +0300 In-Reply-To: (aspriel's message of "Mon, 13 Jun 2022 05:19:29 -0400") Message-ID: <87fsilo9so.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org aspriel@gmail.com writes: > Instead of using EXPORT_SYMBOL() use namespace variant and only if > build vendor-specific code as separate module. The commit log should always answer to the question "why?". -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches