From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF35C433F5 for ; Wed, 6 Apr 2022 08:02:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343879AbiDFIE0 (ORCPT ); Wed, 6 Apr 2022 04:04:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376957AbiDFH6V (ORCPT ); Wed, 6 Apr 2022 03:58:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF7B01C2A3C; Tue, 5 Apr 2022 22:44:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD6C161841; Wed, 6 Apr 2022 05:44:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9477C385A1; Wed, 6 Apr 2022 05:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649223841; bh=yC36iEkxg58Jk7HR6Fw3kJOeOrW6HPs3LGEP1J9Hxkw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aTawiqPlLmtbK7yWUuMuIqu1/TxtSQovS4CTRy4usxtr2MNVucy+iBU++5bkUcBKi UzV+hBTDcfP9m7Zu+pNTPItLkrc0hX52568BmmspOz5sT3SehUTaQpuXk3TZiJ0CKW U3rQCrrXIqsAMjLlOdjNbx9Y6L7mvqSn6yr56N5qj4aTFvuXgfIvDLOEwBnAqCJ54X Ag7GXdp6zipXGImE+ZZMrThcaexgYqAbiljX1uBzZjB4Kt9HYCs7nIKE2OhhUk0EIl pZ6E2jNcYwYzR/+dqMDDV5a5DgjMdXkuaaJ236rp7WWXdUteNlEJawdj9+Tq3GAoCW z4qA4agVuXDsA== From: Kalle Valo To: Borislav Petkov Cc: LKML , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 08/11] mt76: Fix undefined behavior due to shift overflowing the constant References: <20220405151517.29753-1-bp@alien8.de> <20220405151517.29753-9-bp@alien8.de> Date: Wed, 06 Apr 2022 08:43:53 +0300 In-Reply-To: <20220405151517.29753-9-bp@alien8.de> (Borislav Petkov's message of "Tue, 5 Apr 2022 17:15:14 +0200") Message-ID: <87fsmqrckm.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Borislav Petkov writes: > From: Borislav Petkov > > Fix: > > drivers/net/wireless/mediatek/mt76/mt76x2/pci.c: In function =E2=80=98m= t76x2e_probe=E2=80=99: > ././include/linux/compiler_types.h:352:38: error: call to =E2=80=98__co= mpiletime_assert_946=E2=80=99 \ > declared with attribute error: FIELD_PREP: mask is not constant > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER_= _) > > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory > details as to why it triggers with older gccs only. > > Signed-off-by: Borislav Petkov As this fixes a compiler warning in Linus' tree, I would like to take this to wireless tree and I assigned this to myself in patchwork. Felix, ack? --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes