* [PATCH 08/11] mt76: Fix undefined behavior due to shift overflowing the constant [not found] <20220405151517.29753-1-bp@alien8.de> @ 2022-04-05 15:15 ` Borislav Petkov 2022-04-06 5:43 ` Kalle Valo 2022-04-10 12:20 ` Kalle Valo [not found] ` <20220405151517.29753-7-bp@alien8.de> 1 sibling, 2 replies; 9+ messages in thread From: Borislav Petkov @ 2022-04-05 15:15 UTC (permalink / raw) To: LKML Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen, Sean Wang, Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless, netdev From: Borislav Petkov <bp@suse.de> Fix: drivers/net/wireless/mediatek/mt76/mt76x2/pci.c: In function ‘mt76x2e_probe’: ././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_946’ \ declared with attribute error: FIELD_PREP: mask is not constant _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory details as to why it triggers with older gccs only. Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Felix Fietkau <nbd@nbd.name> Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> Cc: Ryder Lee <ryder.lee@mediatek.com> Cc: Shayne Chen <shayne.chen@mediatek.com> Cc: Sean Wang <sean.wang@mediatek.com> Cc: Kalle Valo <kvalo@kernel.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org --- drivers/net/wireless/mediatek/mt76/mt76x2/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c b/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c index 8a22ee581674..df85ebc6e1df 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c @@ -80,7 +80,7 @@ mt76x2e_probe(struct pci_dev *pdev, const struct pci_device_id *id) mt76_rmw_field(dev, 0x15a10, 0x1f << 16, 0x9); /* RG_SSUSB_G1_CDR_BIC_LTR = 0xf */ - mt76_rmw_field(dev, 0x15a0c, 0xf << 28, 0xf); + mt76_rmw_field(dev, 0x15a0c, 0xfU << 28, 0xf); /* RG_SSUSB_CDR_BR_PE1D = 0x3 */ mt76_rmw_field(dev, 0x15c58, 0x3 << 6, 0x3); -- 2.35.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 08/11] mt76: Fix undefined behavior due to shift overflowing the constant 2022-04-05 15:15 ` [PATCH 08/11] mt76: Fix undefined behavior due to shift overflowing the constant Borislav Petkov @ 2022-04-06 5:43 ` Kalle Valo 2022-04-10 12:20 ` Kalle Valo 1 sibling, 0 replies; 9+ messages in thread From: Kalle Valo @ 2022-04-06 5:43 UTC (permalink / raw) To: Borislav Petkov Cc: LKML, Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen, Sean Wang, David S. Miller, Jakub Kicinski, linux-wireless, netdev Borislav Petkov <bp@alien8.de> writes: > From: Borislav Petkov <bp@suse.de> > > Fix: > > drivers/net/wireless/mediatek/mt76/mt76x2/pci.c: In function ‘mt76x2e_probe’: > ././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_946’ \ > declared with attribute error: FIELD_PREP: mask is not constant > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory > details as to why it triggers with older gccs only. > > Signed-off-by: Borislav Petkov <bp@suse.de> As this fixes a compiler warning in Linus' tree, I would like to take this to wireless tree and I assigned this to myself in patchwork. Felix, ack? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 08/11] mt76: Fix undefined behavior due to shift overflowing the constant 2022-04-05 15:15 ` [PATCH 08/11] mt76: Fix undefined behavior due to shift overflowing the constant Borislav Petkov 2022-04-06 5:43 ` Kalle Valo @ 2022-04-10 12:20 ` Kalle Valo 1 sibling, 0 replies; 9+ messages in thread From: Kalle Valo @ 2022-04-10 12:20 UTC (permalink / raw) To: Borislav Petkov Cc: LKML, Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen, Sean Wang, David S. Miller, Jakub Kicinski, linux-wireless, netdev Borislav Petkov <bp@alien8.de> wrote: > From: Borislav Petkov <bp@suse.de> > > Fix: > > drivers/net/wireless/mediatek/mt76/mt76x2/pci.c: In function ‘mt76x2e_probe’: > ././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_946’ \ > declared with attribute error: FIELD_PREP: mask is not constant > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory > details as to why it triggers with older gccs only. > > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: Felix Fietkau <nbd@nbd.name> > Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> > Cc: Ryder Lee <ryder.lee@mediatek.com> > Cc: Shayne Chen <shayne.chen@mediatek.com> > Cc: Sean Wang <sean.wang@mediatek.com> > Cc: Kalle Valo <kvalo@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org Patch applied to wireless.git, thanks. dbc2b1764734 mt76: Fix undefined behavior due to shift overflowing the constant -- https://patchwork.kernel.org/project/linux-wireless/patch/20220405151517.29753-9-bp@alien8.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <20220405151517.29753-7-bp@alien8.de>]
* Re: [PATCH 06/11] brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant [not found] ` <20220405151517.29753-7-bp@alien8.de> @ 2022-04-05 15:25 ` Kalle Valo 2022-04-05 16:06 ` Borislav Petkov 0 siblings, 1 reply; 9+ messages in thread From: Kalle Valo @ 2022-04-05 15:25 UTC (permalink / raw) To: Borislav Petkov Cc: LKML, Arend van Spriel, Franky Lin, Hante Meuleman, David S. Miller, Jakub Kicinski, brcm80211-dev-list.pdl, netdev, linux-wireless + linux-wireless Borislav Petkov <bp@alien8.de> writes: > From: Borislav Petkov <bp@suse.de> > > Fix: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: In function ‘brcmf_sdio_drivestrengthinit’: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3798:2: error: case label does not reduce to an integer constant > case SDIOD_DRVSTR_KEY(BRCM_CC_43143_CHIP_ID, 17): > ^~~~ > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3809:2: error: case label does not reduce to an integer constant > case SDIOD_DRVSTR_KEY(BRCM_CC_43362_CHIP_ID, 13): > ^~~~ > > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory > details as to why it triggers with older gccs only. > > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: Arend van Spriel <aspriel@gmail.com> > Cc: Franky Lin <franky.lin@broadcom.com> > Cc: Hante Meuleman <hante.meuleman@broadcom.com> > Cc: Kalle Valo <kvalo@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: brcm80211-dev-list.pdl@broadcom.com > Cc: netdev@vger.kernel.org > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > index ba3c159111d3..d78ccc223709 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > @@ -557,7 +557,7 @@ enum brcmf_sdio_frmtype { > BRCMF_SDIO_FT_SUB, > }; > > -#define SDIOD_DRVSTR_KEY(chip, pmu) (((chip) << 16) | (pmu)) > +#define SDIOD_DRVSTR_KEY(chip, pmu) (((unsigned int)(chip) << 16) | (pmu)) Via which tree is this going? I assume not the wireless tree, so: Acked-by: Kalle Valo <kvalo@kernel.org> -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 06/11] brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant 2022-04-05 15:25 ` [PATCH 06/11] brcmfmac: sdio: " Kalle Valo @ 2022-04-05 16:06 ` Borislav Petkov 2022-04-05 16:37 ` Kalle Valo 0 siblings, 1 reply; 9+ messages in thread From: Borislav Petkov @ 2022-04-05 16:06 UTC (permalink / raw) To: Kalle Valo Cc: LKML, Arend van Spriel, Franky Lin, Hante Meuleman, David S. Miller, Jakub Kicinski, brcm80211-dev-list.pdl, netdev, linux-wireless On Tue, Apr 05, 2022 at 06:25:30PM +0300, Kalle Valo wrote: > Via which tree is this going? I assume not the wireless tree, so: Whoever picks it up. > Acked-by: Kalle Valo <kvalo@kernel.org> Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 06/11] brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant 2022-04-05 16:06 ` Borislav Petkov @ 2022-04-05 16:37 ` Kalle Valo 2022-04-05 16:55 ` [RESEND PATCH " Borislav Petkov 0 siblings, 1 reply; 9+ messages in thread From: Kalle Valo @ 2022-04-05 16:37 UTC (permalink / raw) To: Borislav Petkov Cc: LKML, Arend van Spriel, Franky Lin, Hante Meuleman, David S. Miller, Jakub Kicinski, brcm80211-dev-list.pdl, netdev, linux-wireless Borislav Petkov <bp@alien8.de> writes: > On Tue, Apr 05, 2022 at 06:25:30PM +0300, Kalle Valo wrote: >> Via which tree is this going? I assume not the wireless tree, so: > > Whoever picks it up. It would be good to have a plan so the patch is not forgotten :) Normally brcmfmac patches go via the wireless tree, so I could take this patch. But you didn't CC linux-wireless so our patchwork doesn't see it. So if you want me to take this you need to resend. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 9+ messages in thread
* [RESEND PATCH 06/11] brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant 2022-04-05 16:37 ` Kalle Valo @ 2022-04-05 16:55 ` Borislav Petkov 2022-04-05 19:11 ` Arend van Spriel 2022-04-10 12:20 ` Kalle Valo 0 siblings, 2 replies; 9+ messages in thread From: Borislav Petkov @ 2022-04-05 16:55 UTC (permalink / raw) To: Kalle Valo Cc: LKML, Arend van Spriel, Franky Lin, Hante Meuleman, David S. Miller, Jakub Kicinski, brcm80211-dev-list.pdl, netdev, linux-wireless Fix: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: In function ‘brcmf_sdio_drivestrengthinit’: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3798:2: error: case label does not reduce to an integer constant case SDIOD_DRVSTR_KEY(BRCM_CC_43143_CHIP_ID, 17): ^~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3809:2: error: case label does not reduce to an integer constant case SDIOD_DRVSTR_KEY(BRCM_CC_43362_CHIP_ID, 13): ^~~~ See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory details as to why it triggers with older gccs only. Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Arend van Spriel <aspriel@gmail.com> Cc: Franky Lin <franky.lin@broadcom.com> Cc: Hante Meuleman <hante.meuleman@broadcom.com> Cc: Kalle Valo <kvalo@kernel.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: brcm80211-dev-list.pdl@broadcom.com Cc: netdev@vger.kernel.org --- Resend, this time with linux-wireless on Cc so that patchwork can pick it up. Thx. drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index ba3c159111d3..d78ccc223709 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -557,7 +557,7 @@ enum brcmf_sdio_frmtype { BRCMF_SDIO_FT_SUB, }; -#define SDIOD_DRVSTR_KEY(chip, pmu) (((chip) << 16) | (pmu)) +#define SDIOD_DRVSTR_KEY(chip, pmu) (((unsigned int)(chip) << 16) | (pmu)) /* SDIO Pad drive strength to select value mappings */ struct sdiod_drive_str { -- 2.35.1 -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [RESEND PATCH 06/11] brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant 2022-04-05 16:55 ` [RESEND PATCH " Borislav Petkov @ 2022-04-05 19:11 ` Arend van Spriel 2022-04-10 12:20 ` Kalle Valo 1 sibling, 0 replies; 9+ messages in thread From: Arend van Spriel @ 2022-04-05 19:11 UTC (permalink / raw) To: Borislav Petkov, Kalle Valo Cc: LKML, Arend van Spriel, Franky Lin, Hante Meuleman, David S. Miller, Jakub Kicinski, brcm80211-dev-list.pdl, netdev, linux-wireless [-- Attachment #1: Type: text/plain, Size: 1151 bytes --] On 4/5/2022 6:55 PM, Borislav Petkov wrote: > Fix: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: In function ‘brcmf_sdio_drivestrengthinit’: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3798:2: error: case label does not reduce to an integer constant > case SDIOD_DRVSTR_KEY(BRCM_CC_43143_CHIP_ID, 17): > ^~~~ > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3809:2: error: case label does not reduce to an integer constant > case SDIOD_DRVSTR_KEY(BRCM_CC_43362_CHIP_ID, 13): > ^~~~ > > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory > details as to why it triggers with older gccs only. The details aren't that gory ;-) Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: Arend van Spriel <aspriel@gmail.com> > Cc: Franky Lin <franky.lin@broadcom.com> > Cc: Hante Meuleman <hante.meuleman@broadcom.com> > Cc: Kalle Valo <kvalo@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: brcm80211-dev-list.pdl@broadcom.com > Cc: netdev@vger.kernel.org [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4219 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RESEND PATCH 06/11] brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant 2022-04-05 16:55 ` [RESEND PATCH " Borislav Petkov 2022-04-05 19:11 ` Arend van Spriel @ 2022-04-10 12:20 ` Kalle Valo 1 sibling, 0 replies; 9+ messages in thread From: Kalle Valo @ 2022-04-10 12:20 UTC (permalink / raw) To: Borislav Petkov Cc: LKML, Arend van Spriel, Franky Lin, Hante Meuleman, David S. Miller, Jakub Kicinski, brcm80211-dev-list.pdl, netdev, linux-wireless Borislav Petkov <bp@alien8.de> wrote: > Fix: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: In function ‘brcmf_sdio_drivestrengthinit’: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3798:2: error: case label does not reduce to an integer constant > case SDIOD_DRVSTR_KEY(BRCM_CC_43143_CHIP_ID, 17): > ^~~~ > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3809:2: error: case label does not reduce to an integer constant > case SDIOD_DRVSTR_KEY(BRCM_CC_43362_CHIP_ID, 13): > ^~~~ > > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory > details as to why it triggers with older gccs only. > > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: Arend van Spriel <aspriel@gmail.com> > Cc: Franky Lin <franky.lin@broadcom.com> > Cc: Hante Meuleman <hante.meuleman@broadcom.com> > Cc: Kalle Valo <kvalo@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: brcm80211-dev-list.pdl@broadcom.com > Cc: netdev@vger.kernel.org > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Patch applied to wireless.git, thanks. 6fb3a5868b21 brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant -- https://patchwork.kernel.org/project/linux-wireless/patch/Ykx0iRlvtBnKqtbG@zn.tnic/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-04-10 12:21 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220405151517.29753-1-bp@alien8.de>
2022-04-05 15:15 ` [PATCH 08/11] mt76: Fix undefined behavior due to shift overflowing the constant Borislav Petkov
2022-04-06 5:43 ` Kalle Valo
2022-04-10 12:20 ` Kalle Valo
[not found] ` <20220405151517.29753-7-bp@alien8.de>
2022-04-05 15:25 ` [PATCH 06/11] brcmfmac: sdio: " Kalle Valo
2022-04-05 16:06 ` Borislav Petkov
2022-04-05 16:37 ` Kalle Valo
2022-04-05 16:55 ` [RESEND PATCH " Borislav Petkov
2022-04-05 19:11 ` Arend van Spriel
2022-04-10 12:20 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).