From: Kalle Valo <kvalo@codeaurora.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@infineon.com>,
Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
Wright Feng <wright.feng@infineon.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com
Subject: Re: [PATCH] brcmfmac: firmware: Treat EFI nvram ccode=XT the same as ccode=XV
Date: Tue, 05 Oct 2021 08:36:48 +0300 [thread overview]
Message-ID: <87fstgghhr.fsf@codeaurora.org> (raw)
In-Reply-To: <20211003160325.119696-1-hdegoede@redhat.com> (Hans de Goede's message of "Sun, 3 Oct 2021 18:03:25 +0200")
Hans de Goede <hdegoede@redhat.com> writes:
> In some cases the EFI-var stored nvram contains "ccode=ALL", "ccode=XV"
> or "ccode=XT", to specify "worldwide" compatible settings, but these
> ccode-s do not work properly. "ccode=ALL" causes channels 12 and 13 to
> not be available, "ccode=XV" / "ccode=XT" may cause all 5GHz channels
> to not be available.
>
> ccode="ALL" and ccode="XV" where already being replaced with ccode="X2"
> with a bit of special handling for nvram settings coming from an EFI
> variable. Extend this handling to also deal with nvram settings from
> EFI variables which contain "ccode=XT", which has similar issues to
> "ccode=XV".
>
> This fixes 5GHz wifi not working on the HP ElitePad 1000 G2.
>
> This was also tested on a Lenovo Thinkpad 8 tablet which also uses
> "ccode=XT" and this causes no adverse effects there.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
To me worldwide compatible settings mean that channels 12 and 13 should
be disabled, so I'm quite hesitant about this patch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-10-05 5:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 16:03 [PATCH] brcmfmac: firmware: Treat EFI nvram ccode=XT the same as ccode=XV Hans de Goede
2021-10-05 5:36 ` Kalle Valo [this message]
2021-10-05 8:02 ` Hans de Goede
2021-10-05 8:37 ` Arend van Spriel
2021-10-11 6:08 ` Kalle Valo
2021-10-23 11:12 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fstgghhr.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).