Re: [PATCH] rsi: Fix module dev_oper_mode parameter description

Re: [PATCH] rsi: Fix module dev_oper_mode parameter description

[Kalle Valo]

+ linux-wireless

Marek Vasut <marex@denx.de> writes:

> The module parameters are missing dev_oper_mode 12, BT classic alone,
> add it. Moreover, the parameters encode newlines, which ends up being
> printed malformed e.g. by modinfo, so fix that too.
>
> However, the module parameter string is duplicated in both USB and SDIO
> modules and the dev_oper_mode mode enumeration in those module parameters
> is a duplicate of macros used by the driver. Furthermore, the enumeration
> is confusing.
>
> So, deduplicate the module parameter string and use __stringify() to
> encode the correct mode enumeration values into the module parameter
> string. Finally, replace 'Wi-Fi' with 'Wi-Fi alone' and 'BT' with
> 'BT classic alone' to clarify what those modes really mean.
>
> Fixes: 898b255339310 ("rsi: add module parameter operating mode")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Amitkumar Karwar <amit.karwar@redpinesignals.com>
> Cc: Angus Ainslie <angus@akkea.ca>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: Karun Eagalapati <karun256@gmail.com>
> Cc: Martin Fuzzey <martin.fuzzey@flowbird.group>
> Cc: Martin Kepplinger <martink@posteo.de>
> Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
> Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> Cc: Siva Rebbagondla <siva8118@gmail.com>
> To: netdev@vger.kernel.org
> Cc: <stable@vger.kernel.org> # 4.17+
> ---
>  drivers/net/wireless/rsi/rsi_91x_sdio.c |  5 +----
>  drivers/net/wireless/rsi/rsi_91x_usb.c  |  5 +----
>  drivers/net/wireless/rsi/rsi_hal.h      | 11 +++++++++++
>  3 files changed, 13 insertions(+), 8 deletions(-)

linux-wireless is not included so patchwork won't see this patch. Please
resubmit (as v2) and include linux-wireless, more info in the wiki
below.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches