Re: [PATCH v3 4/4] iwlwifi: mvm: add vendor commands needed for iwlmei

[Kalle Valo <kvalo@codeaurora.org>]

Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:

> Add the vendor commands that must be used by the network manager
> to allow proper operation of iwlmei.
>
> * Send information on the AP CSME is connected to
> * Notify the userspace when roaming is forbidden
> * Allow the userspace to require ownership
>
> Co-Developed-by: Ayala Beker <ayala.beker@intel.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/Kconfig    |  11 ++
>  .../net/wireless/intel/iwlwifi/mvm/Makefile   |   1 +
>  .../net/wireless/intel/iwlwifi/mvm/mac80211.c |   2 +
>  drivers/net/wireless/intel/iwlwifi/mvm/mvm.h  |   9 +-
>  .../wireless/intel/iwlwifi/mvm/vendor-cmd.c   | 186 ++++++++++++++++++
>  5 files changed, 203 insertions(+), 6 deletions(-)
>  create mode 100644 drivers/net/wireless/intel/iwlwifi/mvm/vendor-cmd.c
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index 629aaa26a230..f91516d08b28 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -92,11 +92,22 @@ config IWLWIFI_BCAST_FILTERING
>  	  If unsure, don't enable this option, as some programs might
>  	  expect incoming broadcasts for their normal operations.
>  
> +config IWLMVM_VENDOR_CMDS
> +	bool "Enable vendor commands"
> +	depends on IWLMVM
> +	help
> +	  This option enables support for vendor commands, including some
> +	  that don't have their own Kconfig option. Other Kconfig options
> +	  depend on this one as well.
> +
> +	  This is not enabled by default, if unsure, say N.

Why do we need a new Kconfig option? Why not always include it in the
compilation?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches