From: Kalle Valo <kvalo@codeaurora.org>
To: Pkshih <pkshih@realtek.com>
Cc: Tony Chuang <yhchuang@realtek.com>,
"xiakaixu1987\@gmail.com" <xiakaixu1987@gmail.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kaixuxia\@tencent.com" <kaixuxia@tencent.com>
Subject: Re: [PATCH] rtw88: coex: remove the unreached code in rtw_coex_set_tdma
Date: Tue, 17 Nov 2020 10:21:37 +0200 [thread overview]
Message-ID: <87ft58z94e.fsf@codeaurora.org> (raw)
In-Reply-To: <1605600696.20048.11.camel@realtek.com> (pkshih@realtek.com's message of "Tue, 17 Nov 2020 08:12:40 +0000")
Pkshih <pkshih@realtek.com> writes:
> On Sat, 2020-11-14 at 15:22 +0000, xiakaixu1987@gmail.com wrote:
>> From: Kaixu Xia <kaixuxia@tencent.com>
>>
>> The value of the bool variable ap_enable is always false, so the first
>> if branch is unreached code. Remove it.
>>
>> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
>> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
>> ---
>> drivers/net/wireless/realtek/rtw88/coex.c | 12 +-----------
>> 1 file changed, 1 insertion(+), 11 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtw88/coex.c
>> b/drivers/net/wireless/realtek/rtw88/coex.c
>> index aa08fd7d9fcd..9c7963e45755 100644
>> --- a/drivers/net/wireless/realtek/rtw88/coex.c
>> +++ b/drivers/net/wireless/realtek/rtw88/coex.c
>> @@ -863,18 +863,8 @@ static void rtw_coex_set_tdma(struct rtw_dev *rtwdev, u8
>> byte1, u8 byte2,
>> struct rtw_coex_dm *coex_dm = &coex->dm;
>> struct rtw_chip_info *chip = rtwdev->chip;
>> u8 ps_type = COEX_PS_WIFI_NATIVE;
>> - bool ap_enable = false;
>
> The variable 'ap_enable' is used to indicate a vif is running in AP mode.
> At the first coex version, rtw88 doesn't support AP mode yet, so ap_enable
> is set to false. For now, AP mode is ready, and I can send a patch to set
> proper value depends on vif mode.
>
> Since I'm submitting coex patches to upgrade the code. In order to avoid
> conflicting, I'll send the patch to set proper ap_enable after all my patches
> are merged.
Ok, I'll then drop this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-11-17 8:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 15:22 [PATCH] rtw88: coex: remove the unreached code in rtw_coex_set_tdma xiakaixu1987
2020-11-17 8:12 ` Pkshih
2020-11-17 8:21 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft58z94e.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=kaixuxia@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=xiakaixu1987@gmail.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).