From: Kalle Valo <kvalo@codeaurora.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org,
lorenzo.bianconi@redhat.com, sean.wang@mediatek.com,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mt76: mt7663: add the possibility to load firmware v2
Date: Tue, 28 Apr 2020 14:07:49 +0300 [thread overview]
Message-ID: <87ftcnj2be.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <db72b648024aba3243ee3b7deceb548c9bc2bdf1.1587911939.git.lorenzo@kernel.org> (Lorenzo Bianconi's message of "Sun, 26 Apr 2020 16:40:18 +0200")
Lorenzo Bianconi <lorenzo@kernel.org> writes:
> mt7663 firmware v2 is used for embedded devices since it has more completed
> features in AP mode.
> Add the capability to specify in mt7615 Kconfig which firmware load first
> (v3 or v2) and fallback to the other one if the selected firmware fails
> to load
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> .../net/wireless/mediatek/mt76/mt7615/Kconfig | 13 +++++
> .../net/wireless/mediatek/mt76/mt7615/mcu.c | 50 ++++++++++++++++---
> .../wireless/mediatek/mt76/mt7615/mt7615.h | 6 ++-
> .../net/wireless/mediatek/mt76/mt7615/pci.c | 2 +
> .../net/wireless/mediatek/mt76/mt7615/usb.c | 2 +
> 5 files changed, 65 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/Kconfig b/drivers/net/wireless/mediatek/mt76/mt7615/Kconfig
> index e25db1135eda..c04d6a182bf0 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/Kconfig
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/Kconfig
> @@ -38,3 +38,16 @@ config MT7663U
> This adds support for MT7663U 802.11ax 2x2:2 wireless devices.
>
> To compile this driver as a module, choose M here.
> +
> +config MT7615_OFFLOAD_FIRMWARE
> + bool "Prefer client mode offload firmware (MT7663)"
> + depends on MT7615E || MT7663U
> + default y
> + help
> + Load MT7663 client mode offload firmware (v3) as primary option
> + and fallback to MT7663 firmware v2 in case of failure.
> + If MT7615_OFFLOAD_FIRMWARE is not selected MT7663 firmware v2
> + will be used as primary option.
> + MT7663 client mode offload firmware supports low power features
> + (hw frequency scanning, scheduled frequency scanning, WoW,
> + 802.11 power save) but is more limited in AP mode
Why does this need a compile time config? Wouldn't some kind of runtime
configuration be better?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-28 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 14:40 [PATCH] mt76: mt7663: add the possibility to load firmware v2 Lorenzo Bianconi
2020-04-28 11:07 ` Kalle Valo [this message]
2020-04-28 11:16 ` Felix Fietkau
2020-04-28 11:38 ` Kalle Valo
2020-04-28 13:25 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftcnj2be.fsf@tynnyri.adurom.net \
--to=kvalo@codeaurora.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).