From: Kalle Valo <kvalo@codeaurora.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Wen Gong <wgong@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH net-next] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large()
Date: Tue, 28 Apr 2020 12:37:47 +0300 [thread overview]
Message-ID: <87ftcoeys4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200427104348.13570-1-weiyongjun1@huawei.com> (Wei Yongjun's message of "Mon, 27 Apr 2020 10:43:48 +0000")
Wei Yongjun <weiyongjun1@huawei.com> writes:
> 'cmd' is malloced in ath10k_bmi_lz_data_large() and should be freed
> before leaving from the error handling cases, otherwise it will cause
> memory leak.
>
> Fixes: d58f466a5dee ("ath10k: add large size for BMI download data for SDIO")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/wireless/ath/ath10k/bmi.c | 1 +
> 1 file changed, 1 insertion(+)
Please don't add "net-next" to wireless-driver patches (ath10k, ath11k
etc), because we use different trees. You can add "-next" or
"wireless-driver-next" if you want, but even that is not necessary as I
apply patches to -next by default.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-28 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 10:43 [PATCH net-next] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large() Wei Yongjun
2020-04-28 9:37 ` Kalle Valo [this message]
2020-05-04 8:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftcoeys4.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).