* [PATCH net-next] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large()
@ 2020-04-27 10:43 Wei Yongjun
2020-04-28 9:37 ` Kalle Valo
2020-05-04 8:53 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2020-04-27 10:43 UTC (permalink / raw)
To: Kalle Valo, Wen Gong; +Cc: Wei Yongjun, ath10k, linux-wireless, kernel-janitors
'cmd' is malloced in ath10k_bmi_lz_data_large() and should be freed
before leaving from the error handling cases, otherwise it will cause
memory leak.
Fixes: d58f466a5dee ("ath10k: add large size for BMI download data for SDIO")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wireless/ath/ath10k/bmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath10k/bmi.c b/drivers/net/wireless/ath/ath10k/bmi.c
index ea908107581d..5b6db6e66f65 100644
--- a/drivers/net/wireless/ath/ath10k/bmi.c
+++ b/drivers/net/wireless/ath/ath10k/bmi.c
@@ -380,6 +380,7 @@ static int ath10k_bmi_lz_data_large(struct ath10k *ar, const void *buffer, u32 l
NULL, NULL);
if (ret) {
ath10k_warn(ar, "unable to write to the device\n");
+ kfree(cmd);
return ret;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large()
2020-04-27 10:43 [PATCH net-next] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large() Wei Yongjun
@ 2020-04-28 9:37 ` Kalle Valo
2020-05-04 8:53 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-04-28 9:37 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Wen Gong, linux-wireless, kernel-janitors, ath10k
Wei Yongjun <weiyongjun1@huawei.com> writes:
> 'cmd' is malloced in ath10k_bmi_lz_data_large() and should be freed
> before leaving from the error handling cases, otherwise it will cause
> memory leak.
>
> Fixes: d58f466a5dee ("ath10k: add large size for BMI download data for SDIO")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/wireless/ath/ath10k/bmi.c | 1 +
> 1 file changed, 1 insertion(+)
Please don't add "net-next" to wireless-driver patches (ath10k, ath11k
etc), because we use different trees. You can add "-next" or
"wireless-driver-next" if you want, but even that is not necessary as I
apply patches to -next by default.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large()
2020-04-27 10:43 [PATCH net-next] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large() Wei Yongjun
2020-04-28 9:37 ` Kalle Valo
@ 2020-05-04 8:53 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-05-04 8:53 UTC (permalink / raw)
To: Wei Yongjun
Cc: Wen Gong, Wei Yongjun, ath10k, linux-wireless, kernel-janitors
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> 'cmd' is malloced in ath10k_bmi_lz_data_large() and should be freed
> before leaving from the error handling cases, otherwise it will cause
> memory leak.
>
> Fixes: d58f466a5dee ("ath10k: add large size for BMI download data for SDIO")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
2326aa011967 ath10k: fix possible memory leak in ath10k_bmi_lz_data_large()
--
https://patchwork.kernel.org/patch/11511841/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-04 8:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-27 10:43 [PATCH net-next] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large() Wei Yongjun
2020-04-28 9:37 ` Kalle Valo
2020-05-04 8:53 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).