Re: [RFC V3 1/2] mac80211: add hw 80211 encapsulation offloading support

["Toke Høiland-Jørgensen" <toke@redhat.com>]

John Crispin <john@phrozen.org> writes:

> On 02/04/2019 11:50, Toke Høiland-Jørgensen wrote:
>> ieee80211_queue_skb() calls ieee80211_get_txq() which treats skb->data
>> like it contains an 802.11 header. That is probably not the intention
>> here, is it?
>>
>> I guess we could augment the TXQ stuctures to also handle 802.3 frames
>> (and introduce ieee80211_queue_skb_8023())? Or would it be better to
>> have a qdisc on 802.3-mode interfaces and push packets back to that? I
>> guess we'd still benefit from per-station queueing of packets even if
>> they are Ethernet frames, which would mean amending the TXQs would be
>> better?
>>
>> -Toke
>
> Hi Toke
>
> This patch guards the usage of the hdr pointer. hdr is only used for non 
> data frames which are not relevant when doing encap mode. The code will 
> then drop into the same path as for 80211 encapsulated frames. IMHO the 
> patch is correct and we do not need an additional 
> ieee80211_queue_skb_8023()  to benefit from per station TXQs. Let me 
> know if i missed something.

Ah, right, sorry, missed the change to ieee80211_get_txq() :)

-Toke