From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FE2C169C4 for ; Tue, 29 Jan 2019 12:18:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BD8B20815 for ; Tue, 29 Jan 2019 12:18:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Zs7oL4Jl"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Wrw9Kau2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727697AbfA2MSx (ORCPT ); Tue, 29 Jan 2019 07:18:53 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:57774 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726790AbfA2MSx (ORCPT ); Tue, 29 Jan 2019 07:18:53 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4A7AE607C6; Tue, 29 Jan 2019 12:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548764332; bh=6hVJpOnyKVTPFmUbCsL+CZwdb5sTyVjbWmxJ6AJy9gI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Zs7oL4Jlk3aEeJ65eUEd0Wz40HrJi6Ow1pMag+HzRMgTu9A0frjqnQ0jL2wGZ5KD8 BjWHl/7hxsBnyJQnxS1uYah/puR8T59eykB6qS2IHSno5HndClnK3KwcJ+OWDv3gQo NKv5EraQb9V+T0B/XO3Yaupcm/wRY+yR5Inh/ctk= Received: from x230.qca.qualcomm.com (unknown [83.145.195.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 75AB9602CB; Tue, 29 Jan 2019 12:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548764331; bh=6hVJpOnyKVTPFmUbCsL+CZwdb5sTyVjbWmxJ6AJy9gI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Wrw9Kau2bhZwoMFR95HRjQYc8eaVlEuHwP1kklyZ0eElMQnGycLzByG/hVRffClsm 22DEiQVL7KyKcXsjqp8wIOXccCcvw9GOtXsVuiTYDrd3WOr5BOT5hl/jtedHqMRAEX l83lQHQNyikB/wDi5ANRS2Ai5uBdGcgnfZ+2VDrA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 75AB9602CB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Felix Fietkau Cc: Stanislaw Gruszka , linux-wireless@vger.kernel.org, Lorenzo Bianconi Subject: Re: [PATCH v2 0/7] mt76x02: Beacon support for USB References: <1548678108-9526-1-git-send-email-sgruszka@redhat.com> <87a7jju1mv.fsf@purkki.adurom.net> <8ec3b133-49eb-3c5f-4c3c-bc2bb4e84cde@nbd.name> <87k1inwtu5.fsf@codeaurora.org> Date: Tue, 29 Jan 2019 14:18:48 +0200 In-Reply-To: (Felix Fietkau's message of "Tue, 29 Jan 2019 13:10:08 +0100") Message-ID: <87fttbwtav.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > On 2019-01-29 13:07, Kalle Valo wrote: >> Felix Fietkau writes: >> >>> On 2019-01-29 12:47, Kalle Valo wrote: >>>> Stanislaw Gruszka writes: >>>> >>>>> We can configure beaconing, but without TBTT interrupt we >>>>> can not support PS buffering. This can be added later using >>>>> kernel hrtimer, if we can keep it in sycn with device timer. >>>>> >>>>> I tested AP and IBSS modes. >>>> >>>> So how does this work reliably so that there's no packet loss with >>>> clients using power save? >>> >>> There will be multicast packet loss for clients using power save. >> >> Isn't that a problem? At least as a normal user I would very frustrated >> if sometimes my connection work and sometimes not, for example if I'm >> trying discover devices from my network. Hopefully nobody won't use USB >> devices for any real AP stuff, but still enabling something which we >> know doesn't work realiably is concerning. > > I agree. Maybe we should leave out the flag for AP mode in this patch > until we have PS buffering and leave the rest of the code intact. At least for me that sounds good. -- Kalle Valo