From: Kalle Valo <kvalo@codeaurora.org>
To: Joe Perches <joe@perches.com>
Cc: Kees Cook <keescook@chromium.org>,
netdev@vger.kernel.org, libertas-dev@lists.infradead.org,
linux-wireless@vger.kernel.org,
Daniel Micay <danielmicay@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libertas: Avoid reading past end of buffer
Date: Thu, 11 May 2017 06:45:58 +0300 [thread overview]
Message-ID: <87fugcvyx5.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1494457506.2028.1.camel@perches.com> (Joe Perches's message of "Wed, 10 May 2017 16:05:06 -0700")
Joe Perches <joe@perches.com> writes:
> unrelated trivia:
>
> lbs_deb_enter is used incorrectly here at
> function exit as both enter and leave calls.
>
> That type of copy/paste defect may be common.
>
> $ git grep -w lbs_deb_enter | wc -l
> 148
> $ git grep -w lbs_deb_leave | wc -l
> 71
>
> One would expect these numbers to be the same.
>
> Another option would be to delete all these
> calls as ftrace function tracing works well.
Yeah, deleting all the enter/exit calls would be better.
--
Kalle Valo
next prev parent reply other threads:[~2017-05-11 3:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 19:24 [PATCH] libertas: Avoid reading past end of buffer Kees Cook
2017-05-10 23:05 ` Joe Perches
2017-05-11 3:45 ` Kalle Valo [this message]
2017-05-10 23:12 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2017-05-09 23:23 Kees Cook
2017-05-10 4:33 ` Joe Perches
2017-05-10 19:06 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fugcvyx5.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=danielmicay@gmail.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).