linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Kalle Valo" <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org, "Felix Fietkau" <nbd@nbd.name>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] Revert "bcma: init serial console directly from ChipCommon code"
Date: Fri, 13 Jan 2017 12:16:50 +0200	[thread overview]
Message-ID: <87fuknl0x9.fsf@codeaurora.org> (raw)
In-Reply-To: <20170112174451.7124-1-zajec5@gmail.com> ("Rafał Miłecki"'s message of "Thu, 12 Jan 2017 18:44:51 +0100")

Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> writes:

> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>
> This reverts commit 4c81acab3816 ("bcma: init serial console directly
> from ChipCommon code") as it broke IRQ assignment. Getting IRQ with
> bcma_core_irq helper on SoC requires MIPS core to be set. It happens
> *after* ChipCommon initialization so we can't do this so early.
>
> This fixes a regression but it seems noone noticed it for about a year.
> It could be it was because serial was still somehow working, just
> without IRQs. It doesn't look like a critical patch / fix.
>
> Reported-by: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>

So this is for 4.11? What about CC stable?

I'll add a Fixes line:

Fixes: 4c81acab3816 ("bcma: init serial console directly from ChipCommon co=
de")

--=20
Kalle Valo

  reply	other threads:[~2017-01-13 10:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-12 17:44 [PATCH] Revert "bcma: init serial console directly from ChipCommon code" Rafał Miłecki
2017-01-13 10:16 ` Kalle Valo [this message]
2017-01-13 10:23   ` Rafał Miłecki
2017-01-13 10:42     ` Kalle Valo
2017-01-13 11:23 ` [PATCH 4.10 fix V2] " Rafał Miłecki
2017-01-17 12:24   ` [4.10, fix, " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fuknl0x9.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=rafal@milecki.pl \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).