From: Kalle Valo <kvalo@codeaurora.org>
To: Steve deRosier <derosier@gmail.com>
Cc: Alan <alan@linux.intel.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro
Date: Thu, 13 Oct 2016 07:50:32 +0300 [thread overview]
Message-ID: <87fuo026p3.fsf@purkki.adurom.net> (raw)
In-Reply-To: <CALupW3D2dsTeixs3z+e9JC_D2D_Bd_AHquHKttCf17OhMqEFUg@mail.gmail.com> (Steve deRosier's message of "Wed, 12 Oct 2016 14:32:18 -0700")
Steve deRosier <derosier@gmail.com> writes:
> Sorry to quibble, but the subsystem label on the commit subject line
> should be "ath6kl:" it's a lower-case "L", not a one.
Heh, I missed that :) I can fix it before I commit.
>> --- a/drivers/net/wireless/ath/ath6kl/sdio.c
>> +++ b/drivers/net/wireless/ath/ath6kl/sdio.c
>> @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
>> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))},
>> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
>> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
>> + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
>> {},
>> };
>>
>>
>
> I see nothing wrong with this if the chip does indeed identify itself
> this way. So please fix the subject and you can add:
>
> Reviewed-by: Steve deRosier <steve.derosier@lairdtech.com>
Thanks.
--
Kalle Valo
next prev parent reply other threads:[~2016-10-13 4:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 18:08 [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro Alan
2016-10-12 21:32 ` Steve deRosier
2016-10-13 4:50 ` Kalle Valo [this message]
2016-10-13 11:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuo026p3.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=alan@linux.intel.com \
--cc=derosier@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox