From: Kalle Valo <kvalo@codeaurora.org>
To: Jaap Jan Meijer <jjmeijer88@gmail.com>
Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com
Subject: Re: [PATCH] Fix regression in Android due to rework .get_station() callback
Date: Fri, 06 May 2016 19:02:25 +0300 [thread overview]
Message-ID: <87futvp432.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAA+NYvS3ksstny_Lzw8mLu6=0uKO0VhjuwCyxS9YC-Pb+FaYJA@mail.gmail.com> (Jaap Jan Meijer's message of "Fri, 6 May 2016 16:57:11 +0100")
Jaap Jan Meijer <jjmeijer88@gmail.com> writes:
> 2016-05-06 16:12 GMT+01:00 Kalle Valo <kvalo@codeaurora.org>:
>> Jaap Jan Meijer <jjmeijer88@gmail.com> writes:
>>
>>> Hi Kalle,
>>>
>>> Op vr 6 mei 2016 12:52 schreef Kalle Valo <kvalo@codeaurora.org>:
>>>
>>>
>>> This has multiple issues:
>>>
>>> o Use your full name.
>>> o Use prefix "brcmfmac: " in the title.
>>>
>>> o I can't find commit f654d13, is the commit id really correct?
>>> o Also check from SubmittingPatches how you should reference commit ids.
>>>
>>>
>>>
>>> Thank you for the feedback, I will send a reworked patch as soon as I get home
>>> next week. Also I did this against v4.4.8 so I'll have to rebase it as well.
>>>
>>> I'm not sure what went wrong with the commit hash, its actually this commit:
>>> 1f0dc59a6de93586fcfc04696a61946408ffc56a.
>>
>> That commit id looks to be valid.
>>
>>> I see you did this commit, maybe you can check if this actually is the root
>>> cause? I'm sure you have a lot more insight into this issue than I do.
I just commited the patch. Broadcom folks (CCed) should be able to
answer better, most likely they missed this patch as the title didn't
have "brcmfmac".
--
Kalle Valo
next prev parent reply other threads:[~2016-05-06 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 13:03 [PATCH] Fix regression in Android due to rework .get_station() callback meijjaa
2016-05-06 11:51 ` Kalle Valo
[not found] ` <CAA+NYvTxA_u1kjwmY+VTnhK0G1b5cEcx2QA90fTTEkci4gWvcQ@mail.gmail.com>
[not found] ` <87wpn7p6dv.fsf@kamboji.qca.qualcomm.com>
2016-05-06 15:57 ` Jaap Jan Meijer
2016-05-06 16:02 ` Kalle Valo [this message]
2016-05-08 11:20 ` Jaap Jan Meijer
2016-05-09 14:17 ` Kalle Valo
2016-05-09 9:11 ` Arend Van Spriel
2016-05-09 14:21 ` Kalle Valo
2016-05-10 11:34 ` Jaap Jan Meijer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87futvp432.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=brcm80211-dev-list@broadcom.com \
--cc=jjmeijer88@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).