From: Kalle Valo <kvalo@codeaurora.org>
To: "Erez\, Maya" <merez@codeaurora.org>
Cc: Lior David <liord@codeaurora.org>,
Maya Erez <qca_merez@qca.qualcomm.com>,
Lior David <qca_liord@qca.qualcomm.com>,
linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com
Subject: Re: [PATCH 2/2] wil6210: add module parameter for alternate interface name
Date: Sat, 02 Apr 2016 17:54:27 +0300 [thread overview]
Message-ID: <87fuv4gixo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <56FFA3D0.7080603@codeaurora.org> (Maya Erez's message of "Sat, 2 Apr 2016 13:49:52 +0300")
"Erez, Maya" <merez@codeaurora.org> writes:
> On 3/30/2016 3:13 PM, Kalle Valo wrote:
>
> Lior David <liord@codeaurora.org> writes:
>
>
> As I see it, it is an issue of classification. Network drivers use a
>
> default
>
> interface name prefix depending on the device type. Ethernet drivers get
>
> "eth%d",
>
> wireless drivers get "wlan%d" and so on. There are even existing drivers
> that give different prefixes based on other conditions, for example see
> drivers/s390/net/ctcm_main.c, ctcm_init_netdevice.
> For our 11ad device, in many platforms it is used as a wifi replacement,
>
> so
>
> the wlan%d name is appropriate, in other platforms it is used as
> a different wireless device for different purposes, so the default
>
> "wigig%d"
>
> prefix seems appropriate.
>
> Every platform works differently, even systemd even has it's own weird
> naming scheme:
>
> https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterf
> aceNames/
>
> I really don't think that we should start working around interface
> naming problems by selecting the name with module parameters. But having
> "wigig%d" as the default sounds like a good idea to me.
>
>
> Thanks, Kalle. We will check your suggestion to change the interface name to
> "wigig%d".
>
> Can you drop this patch for now?
Ok, patch 2 dropped. Patch 1 is still on my queue and will be applied
"really soon now" :)
--
Kalle Valo
prev parent reply other threads:[~2016-04-02 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 20:01 [PATCH 0/2] wil6210 changes Maya Erez
2016-03-21 20:01 ` [PATCH 1/2] wil6210: allow empty WMI commands in debugfs wmi_send Maya Erez
2016-04-04 15:04 ` Kalle Valo
2016-03-21 20:01 ` [PATCH 2/2] wil6210: add module parameter for alternate interface name Maya Erez
2016-03-23 15:27 ` Kalle Valo
2016-03-24 10:04 ` Lior David
2016-03-30 12:13 ` Kalle Valo
[not found] ` <56FFA3D0.7080603@codeaurora.org>
2016-04-02 14:54 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuv4gixo.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=liord@codeaurora.org \
--cc=merez@codeaurora.org \
--cc=qca_liord@qca.qualcomm.com \
--cc=qca_merez@qca.qualcomm.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).