Re: [PATCH 1/5] ath10k: QCA988X hw2.0: add board.bin

[Kalle Valo <kvalo@qca.qualcomm.com>]

Ben Hutchings <ben@decadent.org.uk> writes:

> On Thu, 2015-10-15 at 13:40 +0300, Kalle Valo wrote:
>> In commit 40d14143b787 ("ath10k: add firmware 10.2.4.45 as firmware-4.bin") I
>> forgot to commit board.bin file and that's why it was not included in the
>> commit even I had added an entry to WHENCE. Add that now.
>> 
>> At the same time also add Version field for firmware-4.bin.
>> 
>> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
> [...]
>
> I've applied this and the following 4 patches.  However, I'm not
> entirely happy with copyright acknowledgements going into the
> notice_ath10k*.txt files which aren't referenced anywhere.  It would be
> easy for downstream distributors to miss that they should be packaged
> along with the firmware blobs they relate to.  Please can you combine
> these with the QCA licence file or add references to these files from
> WHENCE?

Combining with the license file is difficult as the notice.txt can be
different between firmware versions, but I can add a reference to
WHENCE. I guess you mean to add a new "File: " line for each .txt file?

-- 
Kalle Valo