From: Kalle Valo <kvalo@codeaurora.org>
To: yuweizheng@139.com
Cc: linux-kernel@vger.kernel.org, ath9k-devel@lists.ath9k.org,
linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com,
netdev@vger.kernel.org, Yuwei Zheng <zhengyuwei@360.cn>
Subject: Re: [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode
Date: Tue, 03 Feb 2015 13:52:29 +0200 [thread overview]
Message-ID: <87fvanxldu.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1422957585-19736-1-git-send-email-yuweizheng@139.com> (yuweizheng@139.com's message of "Tue, 3 Feb 2015 17:59:45 +0800")
yuweizheng@139.com writes:
> From: Yuwei Zheng <yuweizheng@139.com>
>
> In the environment with heavy wifi traffic, set the ar9271 into monitor mode, will
> trigger a deadloop panic.
>
> The ath9k_hif_usb_rx_cb function excute on the interrupt context, and ath9k_rx_tasklet excute
> on the soft irq context. In other words, the ath9k_hif_usb_rx_cb have more chance to excute than
> ath9k_rx_tasklet. So in the worst condition, the rx.rxbuf receive list is always full,
> and the do {}while(true) loop will not be break. The kernel get a soft lockup panic.
The word wrapping is still wrong, please limit the width to 72 chars or
so. But no need to wrap log snippets, they can exceed the limit.
> Signed-off-by: Yuwei Zheng <zhengyuwei@360.cn>
> Signed-off-by: Yuwei Zheng <yuweizheng@139.com>
Why two of these? Please use just one Signed-off-by line. Unless these
are two different persons with the same name :)
--
Kalle Valo
next prev parent reply other threads:[~2015-02-03 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 9:59 [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode yuweizheng
2015-02-03 11:52 ` Kalle Valo [this message]
2015-02-03 14:35 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvanxldu.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuweizheng@139.com \
--cc=zhengyuwei@360.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).