Re: [PATCH 2/2] ath10k: do not ratelimit ath10k_warn messages

[Kalle Valo <kvalo@qca.qualcomm.com>]

greearb@candelatech.com writes:

> These are too important to miss, and if we ever do have some
> that are overly verbose

The thing is that in some platforms excessive amount log messages will
cause watchdog to forcefully reboot the device. So I'm hesitant to
remove this.

First of all, the goal is that ath10k will never issue even a single
warning message. So even if you see just one, it means something is
wrong. And just seeing the first few warnings should give you a pretty
good hint what's going on.

Secondly, it's not like net_ratelimit() will hide all the warning
messages. It will still show some of the messages even if it starts to
throttle them.

Thirdly, if you think net_ratelimit() is throttling too much you can
always tune it yourself:

DEFINE_RATELIMIT_STATE(net_ratelimit_state, 5 * HZ, 10);

> could ratelimit the call to ath10k_warn instead of doing the ratelimit
> inside of ath10k_warn.

Not sure if I got this idea. Only to ratelimit some of the warnings or
what do you mean by ratelimiting it outside ath10k_warn()?

-- 
Kalle Valo