* [PATCH] ath10k: fix the printing of 10.x FW version when FW crashed
@ 2014-01-21 9:21 Chun-Yeow Yeoh
2014-01-23 12:57 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Chun-Yeow Yeoh @ 2014-01-21 9:21 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, kvalo, Chun-Yeow Yeoh
10.x FW has no structure member sw_version_1. Thus,
both fw_version_release and fw_version_build are not
available. The provided fw_version_major is also wrong.
Fix this by using the fw_version from struct wiphy.
Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
---
drivers/net/wireless/ath/ath10k/pci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 29fd197..9179c88 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -833,9 +833,7 @@ static void ath10k_pci_hif_dump_area(struct ath10k *ar)
ath10k_err("firmware crashed!\n");
ath10k_err("hardware name %s version 0x%x\n",
ar->hw_params.name, ar->target_version);
- ath10k_err("firmware version: %u.%u.%u.%u\n", ar->fw_version_major,
- ar->fw_version_minor, ar->fw_version_release,
- ar->fw_version_build);
+ ath10k_err("firmware version: %s\n", ar->hw->wiphy->fw_version);
host_addr = host_interest_item_address(HI_ITEM(hi_failure_state));
ret = ath10k_pci_diag_read_mem(ar, host_addr,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath10k: fix the printing of 10.x FW version when FW crashed
2014-01-21 9:21 [PATCH] ath10k: fix the printing of 10.x FW version when FW crashed Chun-Yeow Yeoh
@ 2014-01-23 12:57 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2014-01-23 12:57 UTC (permalink / raw)
To: Chun-Yeow Yeoh; +Cc: ath10k, linux-wireless
Chun-Yeow Yeoh <yeohchunyeow@gmail.com> writes:
> 10.x FW has no structure member sw_version_1. Thus,
> both fw_version_release and fw_version_build are not
> available. The provided fw_version_major is also wrong.
> Fix this by using the fw_version from struct wiphy.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Thanks, applied.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-23 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-21 9:21 [PATCH] ath10k: fix the printing of 10.x FW version when FW crashed Chun-Yeow Yeoh
2014-01-23 12:57 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).