From: Kalle Valo <kvalo@adurom.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH 1/7] ath5k: optimize tx descriptor setup
Date: Mon, 11 Apr 2011 09:29:28 +0300 [thread overview]
Message-ID: <87fwppmhbr.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1302453139-11437-1-git-send-email-nbd@openwrt.org> (Felix Fietkau's message of "Sun\, 10 Apr 2011 18\:32\:13 +0200")
Felix Fietkau <nbd@openwrt.org> writes:
> Use local variables to reduce the number of load/store operations on uncached
> memory.
A comment in the code would be nice as well. Otherwise later on
someone decides to "optimise" and remove the local variables :)
> /* Clear descriptor */
> - memset(&desc->ud.ds_tx5212, 0, sizeof(struct ath5k_hw_5212_tx_desc));
> + memset(&desc->ud.ds_tx5212.tx_stat, 0,
> + sizeof(desc->ud.ds_tx5212.tx_stat));
Is this an unrelated change? Or maybe I just missed something.
--
Kalle Valo
next prev parent reply other threads:[~2011-04-11 6:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-10 16:32 [PATCH 1/7] ath5k: optimize tx descriptor setup Felix Fietkau
2011-04-10 16:32 ` [PATCH 2/7] ath5k: remove ts_rate from ath5k_tx_status Felix Fietkau
2011-04-10 16:32 ` [PATCH 3/7] ath5k: optimize tx status processing Felix Fietkau
2011-04-10 16:32 ` [PATCH 4/7] ath5k: optimize rx " Felix Fietkau
2011-04-10 16:32 ` [PATCH 5/7] ath5k: remove ts_retry from ath5k_tx_status Felix Fietkau
2011-04-10 16:32 ` [PATCH 6/7] ath5k: clean up debugfs code Felix Fietkau
2011-04-10 16:32 ` [PATCH 7/7] ath5k: reduce interrupt load caused by rx/tx interrupts Felix Fietkau
2011-04-12 7:04 ` [ath5k-devel] [PATCH 5/7] ath5k: remove ts_retry from ath5k_tx_status 海藻敬之
2011-04-12 21:43 ` Felix Fietkau
2011-04-11 6:29 ` Kalle Valo [this message]
2011-04-12 21:55 ` [PATCH 1/7] ath5k: optimize tx descriptor setup Felix Fietkau
2011-04-12 22:07 ` [PATCH v2 " Felix Fietkau
2011-04-13 4:23 ` Sedat Dilek
2011-04-13 12:51 ` John W. Linville
2011-04-13 18:34 ` Kalle Valo
2011-04-14 7:27 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwppmhbr.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).