From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] nl80211: add power save commands
Date: Wed, 17 Feb 2010 11:06:57 +0200 [thread overview]
Message-ID: <87fx50grim.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1266396458.5091.0.camel@jlt3.sipsolutions.net> (Johannes Berg's message of "Wed\, 17 Feb 2010 09\:47\:38 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Tue, 2010-02-16 at 22:10 +0200, Kalle Valo wrote:
>
>> [NL80211_ATTR_COOKIE] = { .type = NLA_U64 },
>> [NL80211_ATTR_TX_RATES] = { .type = NLA_NESTED },
>> + [NL80211_ATTR_PS_STATE] = { .type = NLA_U8 },
>> };
>
> Looks good to me, though typically we use NLA_U32 for enums. Should we
> deviate from that because we won't ever extend this anyway, or should we
> use NLA_U32 to be more consistent?
Good point. In my opinion we should definitely use u32 for
consistency, there's no real reason to use u8 here. If it's ok for
you, I'll send v2 later today which uses u32.
Thank you for the review.
--
Kalle Valo
prev parent reply other threads:[~2010-02-17 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 20:10 [RFC PATCH] nl80211: add power save commands Kalle Valo
2010-02-16 20:13 ` [RFC PATCH 1/2] iw: update nl80211.h to include " Kalle Valo
2010-02-16 20:13 ` [RFC PATCH 2/2] iw: add set/get power_save commands Kalle Valo
2010-02-16 20:19 ` [RFC PATCH] nl80211: add power save commands Luis R. Rodriguez
2010-02-16 20:33 ` Kalle Valo
2010-02-17 7:34 ` Holger Schurig
2010-02-17 8:33 ` Johannes Berg
2010-02-17 13:21 ` Holger Schurig
2010-02-17 13:27 ` Johannes Berg
2010-02-17 13:36 ` Johannes Berg
2010-02-17 13:56 ` Holger Schurig
2010-02-17 14:44 ` Johannes Berg
2010-02-17 9:00 ` Kalle Valo
2010-02-17 8:47 ` Johannes Berg
2010-02-17 9:06 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fx50grim.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).