From: Kalle Valo <kalle.valo@iki.fi>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: at76c50x-usb Broken was: [PATCH] mac80211: allow configure_filter callback to sleep
Date: Mon, 07 Sep 2009 13:45:00 +0300 [thread overview]
Message-ID: <87fxaz2fv7.fsf@litku.valot.fi> (raw)
In-Reply-To: <c4d76b3b0909050711o5f423115qaf1e5c80fded024d@mail.gmail.com> (Jason Andryuk's message of "Sat\, 5 Sep 2009 10\:11\:33 -0400")
Jason Andryuk <jandryuk@gmail.com> writes:
> On Mon, Aug 17, 2009 at 10:24 AM, Kalle Valo<kalle.valo@iki.fi> wrote:
>> BTW, at76c50x-usb is broken currently. The change of providing bssid to
>> the driver only after association broke it. I don't have time to fix it
>> right now, but I try to find some time next week.
>
> Do you know the commit that broke at76c50x-usb? Was it "mac80211:
> unify config_interface and bss_info_changed" or something else?
Actually I believe it was this patch:
commit 9cef873798dfcdc10ff40b02abf1de935ceeba85
Author: Johannes Berg <johannes@sipsolutions.net>
Date: Thu May 14 13:10:14 2009 +0200
mac80211: fix managed mode BSSID handling
Currently, we will ask the driver to configure right away
when somebody changes the desired BSSID. That's totally
strange because then we will configure the driver without
even knowing whether the BSS exists. Change this to only
configure the BSSID when associated, and configure a zero
BSSID when not associated.
I implemented a hack to at76c50x-usb where it checks bssid to see if
association has started and should it use CMD_SCAN or CMD_JOIN. Now that
bssid is set after association at76 broke. I haven't checked yet if this
is really the case, though.
IIRC the reason for the hack was that I didn't manage to get CMD_JOIN
working unless there was a valid bssid.
--
Kalle Valo
prev parent reply other threads:[~2009-09-07 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 14:11 at76c50x-usb Broken was: [PATCH] mac80211: allow configure_filter callback to sleep Jason Andryuk
2009-09-07 10:45 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxaz2fv7.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=jandryuk@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox