linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@nokia.com>
To: "Tomas Winkler" <tomasw@gmail.com>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
	linville@tuxdriver.com, yi.zhu@intel.com,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: make listen_interval be configurable by low level driver
Date: Mon, 14 Jul 2008 16:26:49 +0300	[thread overview]
Message-ID: <87fxqcoaue.fsf@nokia.com> (raw)
In-Reply-To: <1ba2fa240807140546w4f08e32l59ed88dfa1b86403@mail.gmail.com> (ext Tomas Winkler's message of "Mon\, 14 Jul 2008 15\:46\:41 +0300")

Tomas Winkler <tomasw@gmail.com> writes:

>> If this is a knob that should be adjusted then we want to enable users
>> to do it, and if it isn't then we can put a value into mac80211 and fix
>> it. Having drivers make these kinds of decisions is very bad for uniform
>> wireless behaviour.
>
> The same story as with beacon interval. This is for the power
> management. It's really hw dependent for how many beacons we can stay
> dormant.

This stuff is very much hardware dependent, I don't deny that, but
still I would assume that the basic principles are almost the same. We
just need to come up with a good interface for the drivers. Sure, it's
more work now, but if we don't do it, PSM support will eventually get
really messy because all drivers do it somehow differently.

> I really don't know what other vendors do and user should not guess
> this.

Yes, for the user this is too difficult, but I think the driver
shouldn't be making the decision either. So mac80211 stack would be
the most logical choice, and it could be make the decisions based on
user input (or something like that).

-- 
Kalle Valo

  reply	other threads:[~2008-07-14 13:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14 12:31 [PATCH 1/2] mac80211: pass dtim_period to low level driver Tomas Winkler
2008-07-14 12:31 ` [PATCH 2/2] mac80211: make listen_interval be configurable by " Tomas Winkler
2008-07-14 12:38   ` Johannes Berg
2008-07-14 12:46     ` Tomas Winkler
2008-07-14 13:26       ` Kalle Valo [this message]
2008-07-14 21:34         ` Tomas Winkler
2008-07-15  7:21           ` Kalle Valo
2008-07-15  7:30             ` Kalle Valo
2008-07-15  8:15             ` Johannes Berg
2008-07-15  8:13           ` Johannes Berg
2008-07-15  8:12         ` Johannes Berg
2008-07-15  8:29           ` Tomas Winkler
2008-07-15  8:41             ` Johannes Berg
2008-07-15  9:58               ` Helmut Schaa
2008-07-15 10:42               ` Tomas Winkler
2008-07-15 19:35             ` Kalle Valo
2008-07-15 19:30           ` Kalle Valo
2008-07-14 13:13     ` Kalle Valo
2008-07-14 12:36 ` [PATCH 1/2] mac80211: pass dtim_period to " Johannes Berg
2008-07-14 12:38   ` Tomas Winkler
2008-07-14 12:40     ` Johannes Berg
2008-07-14 13:17 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fxqcoaue.fsf@nokia.com \
    --to=kalle.valo@nokia.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomasw@gmail.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).