From: Kalle Valo <kvalo@kernel.org>
To: Kang Yang <quic_kangyang@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3 08/11] wifi: ath12k: delete NSS and TX power setting for monitor vdev
Date: Mon, 28 Oct 2024 09:13:04 +0200 [thread overview]
Message-ID: <87h68w3dkv.fsf@kernel.org> (raw)
In-Reply-To: <f605fb9a-28ad-4aa8-a66a-085a7229f629@quicinc.com> (Kang Yang's message of "Mon, 21 Oct 2024 17:21:11 +0800")
Kang Yang <quic_kangyang@quicinc.com> writes:
> On 10/21/2024 4:46 PM, Kalle Valo wrote:
>> Kang Yang <quic_kangyang@quicinc.com> writes:
>>
>>> ath12k_mac_monitor_vdev_create() will set NSS and TX power for monitor
>>> vdev. But this is not needed for monitor vdev.
>>>
>>> So delete them.
>>>
>>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>>
>>> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
>> Does this fix any known issues? Or is just cleanup?
>
> Clean up
Ok, please always mention this in the commit message. In essence you
need to answer to the question 'why are we doing this?'.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-10-28 7:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 6:56 [PATCH v3 00/11] wifi: ath12k: some fixes and clean up for monitor mode Kang Yang
2024-10-16 6:56 ` [PATCH v3 01/11] wifi: ath12k: remove unused variable monitor_present Kang Yang
2024-10-16 6:56 ` [PATCH v3 02/11] wifi: ath12k: optimize storage size for struct ath12k Kang Yang
2024-10-16 6:56 ` [PATCH v3 03/11] wifi: ath12k: fix struct hal_rx_ppdu_end_user_stats Kang Yang
2024-10-21 8:45 ` Kalle Valo
2024-10-21 8:50 ` Kalle Valo
2024-10-21 9:32 ` Kang Yang
2024-10-28 7:16 ` Kalle Valo
2024-10-16 6:56 ` [PATCH v3 04/11] wifi: ath12k: fix struct hal_rx_ppdu_start Kang Yang
2024-10-16 6:56 ` [PATCH v3 05/11] wifi: ath12k: fix struct hal_rx_phyrx_rssi_legacy_info Kang Yang
2024-10-16 6:56 ` [PATCH v3 06/11] wifi: ath12k: fix struct hal_rx_mpdu_start Kang Yang
2024-10-16 6:56 ` [PATCH v3 07/11] wifi: ath12k: properly handling the state variables of monitor mode Kang Yang
2024-10-16 6:56 ` [PATCH v3 08/11] wifi: ath12k: delete NSS and TX power setting for monitor vdev Kang Yang
2024-10-21 8:46 ` Kalle Valo
2024-10-21 9:21 ` Kang Yang
2024-10-28 7:13 ` Kalle Valo [this message]
2024-10-16 6:56 ` [PATCH v3 09/11] wifi: ath12k: use tail MSDU to get MSDU information Kang Yang
2024-10-16 6:56 ` [PATCH v3 10/11] wifi: ath12k: fix A-MSDU indication in monitor mode Kang Yang
2024-10-16 6:57 ` [PATCH v3 11/11] wifi: ath12k: delete mon reap timer Kang Yang
2024-10-21 8:47 ` Kalle Valo
2024-10-21 9:20 ` Kang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h68w3dkv.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_kangyang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox