linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Larry Finger <Larry.Finger@gmail.com>,
	 Johannes Berg <johannes@sipsolutions.net>,
	 "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>,
	 "Nick Morrow" <morrownr@gmail.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	 "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCHi V2] wifi: rtw88: Add missing VID/PIDs doe 8811CU and 8821CU
Date: Tue, 27 Feb 2024 08:38:48 +0200	[thread overview]
Message-ID: <87h6hu9zt3.fsf@kernel.org> (raw)
In-Reply-To: <aab5bb779e1f470daeb0a4258e4bb764@realtek.com> (Ping-Ke Shih's message of "Tue, 27 Feb 2024 02:56:43 +0000")

Ping-Ke Shih <pkshih@realtek.com> writes:

> Hi Larry,
>
>> -----Original Message-----
>> From: Larry Finger <Larry.Finger@gmail.com>
>> Sent: Tuesday, February 27, 2024 10:35 AM
>> To: Kalle Valo <kvalo@kernel.org>
>> Cc: Johannes Berg <johannes@sipsolutions.net>; linux-wireless@vger.kernel.org; Nick Morrow
>> <morrownr@gmail.com>; Larry Finger <Larry.Finger@lwfinger.net>; Ping-Ke Shih <pkshih@realtek.com>;
>> stable@vger.kernel.org
>> Subject: [PATCHi V2] wifi: rtw88: Add missing VID/PIDs doe 8811CU and 8821CU
>
> Not sure if "doe" is typo?

I think it means "for" but Larry's finger was one key off to the left :) I can fix that.

>> From: Nick Morrow <morrownr@gmail.com>
>> 
>> Purpose: Add VID/PIDs that are known to be missing for this driver.
>> - removed  /* 8811CU */ and /* 8821CU */ as they are redundant
>> since the file is specific to those chips.
>> - removed /* TOTOLINK A650UA v3 */ as the manufacturer. It has a REALTEK
>> VID so it may not be specific to this adapter.
>> 
>> Source is
>> https://1EHFQ.trk.elasticemail.com/tracking/click?d=I82H0YR_W_h175Lb3Nkb0D8i6IqvuhESe0WLnY6P7IVwR1UKvB
>> 0SPxd1Olp3PNJEJTqsu4kyqBXayE0BVd_k7uLFvlTe65Syx2uqLUB-UQSfsKKLkuyE-frMZXSCL7q824UG3Oer614GGEeEz-DNEWHh
>> 43p_e8oz7OouS6gRBEng0
>> Verified and tested.
>> 
>> Signed-off-by: Nick Morrow <morrownr@gmail.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>> 
>
> Did you keep a blank line intentionally? 

I can fix this as well. I'll also move 'cc: stable' to the beginning of
tags.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2024-02-27  6:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27  2:34 [PATCHi V2] wifi: rtw88: Add missing VID/PIDs doe 8811CU and 8821CU Larry Finger
2024-02-27  2:56 ` Ping-Ke Shih
2024-02-27  6:38   ` Kalle Valo [this message]
2024-02-27 15:13     ` Larry Finger
2024-03-05 17:43 ` [PATCH,V2] wifi: rtw88: Add missing VID/PIDs for " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6hu9zt3.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=Larry.Finger@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=morrownr@gmail.com \
    --cc=pkshih@realtek.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).