From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B33E405DD for ; Thu, 7 Dec 2023 13:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="houRMNEI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61A8EC433C8; Thu, 7 Dec 2023 13:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701956252; bh=oCmGs8e7SpjRy+Vd5XKtyFu88CTeYgJP7xGauoAW/Zs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=houRMNEIKs5cps4+ut1rJB6U6ivq4OYj4xgU5uMkj3D172jurecKVSCsnop3dPe9k U1d5J0WTypOBy0mJsBPHkgTzDou4XdkrxEPFJhxqSVBqcsCnzFpTWBC3ckxc/ohIFf bc+BKuc/PmLSE+E3dGpcOm/UKakpZFc2PNUv7QqxDf47q3lcS0wbBMs7CZjNpS39b1 cAVr1z01JphowU1OpdW44MaAaSKWhl/ZdrYATRDEoh5iELzpVv7Pv4ZJ8VB76asH8K BCPwNmqd85v3Klogh8iIZuSOWomr7ZUYonIRCGwlOMVi70dRBCqkPBExMgPVwaRLny tmBnBC7iSl5tA== From: Kalle Valo To: miriam.rachel.korenblit@intel.com Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org, Johannes Berg , Brian Norris Subject: Re: [PATCH 13/13] iwlwifi: pcie: add another missing bh-disable for rxq->lock References: <20231207025018.1022929-1-miriam.rachel.korenblit@intel.com> <20231207044813.acb50fabb4cc.I8f19713c4383707f8be7fc20ff5cc1ecf12429bb@changeid> Date: Thu, 07 Dec 2023 15:37:29 +0200 In-Reply-To: <20231207044813.acb50fabb4cc.I8f19713c4383707f8be7fc20ff5cc1ecf12429bb@changeid> (Miri@web.codeaurora.org's message of "Thu, 7 Dec 2023 04:50:18 +0200") Message-ID: <87h6ku5e1y.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain miriam.rachel.korenblit@intel.com writes: > From: Johannes Berg > > Evidently I had only looked at all the ones in rx.c, and missed this. > Add bh-disable to this use of the rxq->lock as well. > > Fixes: 25edc8f259c7 ("iwlwifi: pcie: properly implement NAPI") > Reported-by: Brian Norris > Signed-off-by: Johannes Berg > Signed-off-by: Miri Korenblit "wifi:" prefix missing. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches