From: Kalle Valo <kvalo@kernel.org>
To: Shiji Yang <yangshiji66@outlook.com>
Cc: helmut.schaa@googlemail.com, linux-wireless@vger.kernel.org,
stf_xl@wp.pl
Subject: Re: [PATCH] wifi: rt2x00: fix rt2800 watchdog function
Date: Thu, 19 Oct 2023 16:33:02 +0300 [thread overview]
Message-ID: <87h6mm20vl.fsf@kernel.org> (raw)
In-Reply-To: <TYAP286MB0315BFF338DEE34898A20584BCD4A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM> (Shiji Yang's message of "Thu, 19 Oct 2023 20:05:13 +0800")
Shiji Yang <yangshiji66@outlook.com> writes:
> On Thu, 19 Oct 2023 07:00:30 +0000, Kalle Valo wrote:
>
>>Shiji Yang <yangshiji66@outlook.com> wrote:
>>
>>> The watchdog function is broken on rt2800 series SoCs. This patch
>>> fixes the incorrect watchdog logic to make it work again.
>>>
>>> 1. Update current wdt queue index if it's not equal to the previous
>>> index. Watchdog compares the current and previous queue index to
>>> judge if the queue hung.
>>> 2. Make sure hung_{rx,tx} 'true' status won't be override by the
>>> normal queue. Any queue hangs should trigger a reset action.
>>> 3. Clear the watchdog counter of all queues before resetting the
>>> hardware. This change may help to avoid the reset loop.
>>> 4. Change hang check function return type to bool as we only need
>>> to return two status, yes or no.
>>>
>>> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
>>
>>Is this patch ok to take?
>
>
> Hi! I think it's ready. I've been testing it for a few weeks.
That question was more towards maintainers Stanislaw, Helmut and other
reviewers :)
That reminds me, is Helmut still maintaining this driver? I haven't seen
an ack from him since 2016. As we nowadays try to keep the MAINTAINERS
up-to-date so should we remove him?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-10-19 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 6:55 [PATCH] wifi: rt2x00: fix rt2800 watchdog function Shiji Yang
2023-10-19 7:00 ` Kalle Valo
2023-10-19 12:05 ` Shiji Yang
2023-10-19 13:33 ` Kalle Valo [this message]
2023-10-19 17:53 ` Stanislaw Gruszka
2023-10-19 18:47 ` Kalle Valo
2023-10-23 17:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6mm20vl.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=stf_xl@wp.pl \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).