From: Kalle Valo <kvalo@kernel.org>
To: Arowa Suliman <arowa@chromium.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [v4] wifi: ath11k: Add crash logging
Date: Tue, 29 Aug 2023 14:53:46 +0300 [thread overview]
Message-ID: <87h6oif4j9.fsf@kernel.org> (raw)
In-Reply-To: <20230714001126.463127-1-arowa@chromium.org> (Arowa Suliman's message of "Thu, 13 Jul 2023 17:10:54 -0700")
Arowa Suliman <arowa@chromium.org> writes:
> Currently, the ath11k driver does not print a crash signature when a
> crash happens. Checked by triggering a simulated crash using the command
> [1] and checking dmesg for logs.
>
> [1] echo assert > /sys/kernel/debug/ath11k/../simulate_fw_crash
>
> Change the crash logging from debug to informational and add a warning
> when firmware crash MHI_CB_EE_RDDM happens.
>
> Tested-on: WCN6855 hw2.0 PCI
> WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23
>
> Signed-off-by: Arowa Suliman <arowa@chromium.org>
I did some cosmetic cleanup to the commit log.
> --- a/drivers/net/wireless/ath/ath11k/mhi.c
> +++ b/drivers/net/wireless/ath/ath11k/mhi.c
> @@ -325,14 +325,15 @@ static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl,
> {
> struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev);
>
> - ath11k_dbg(ab, ATH11K_DBG_BOOT, "notify status reason %s\n",
> - ath11k_mhi_op_callback_to_str(cb));
> + ath11k_info(ab, "notify status reason %s\n",
> + ath11k_mhi_op_callback_to_str(cb));
In my view info, warning and error messages need to be at least somewhat
understandable to the user. I think this message is not understandable
and it should remain as a debug message. So I removed this change.
Please check my changes in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=f9325b14e830f3e8b5a557352e7c65f321bb7b05
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-08-29 11:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 0:10 [v4] wifi: ath11k: Add crash logging Arowa Suliman
2023-07-14 1:30 ` Jeff Johnson
2023-08-29 11:53 ` Kalle Valo [this message]
2023-09-05 13:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6oif4j9.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=arowa@chromium.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).