From: Kalle Valo <kvalo@kernel.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Ping-Ke Shih <pkshih@realtek.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] [v2] wifi: rtlwifi: simplify LED management
Date: Wed, 14 Jun 2023 08:21:30 +0300 [thread overview]
Message-ID: <87h6rad3fp.fsf@kernel.org> (raw)
In-Reply-To: <e030e496-b667-b1de-492b-8b0cc04ffe14@yandex.ru> (Dmitry Antipov's message of "Tue, 13 Jun 2023 11:36:05 +0300")
Dmitry Antipov <dmantipov@yandex.ru> writes:
> On 6/13/23 11:31, Kalle Valo wrote:
>
>> Is there a reason why you are changing error messages to debug messages like here:
>>
>> - pr_err("switch case %#x not processed\n",
>> - pled->ledpin);
>> + rtl_dbg(rtlpriv, COMP_ERR, DBG_LOUD,
>> + "unknown LED pin %d\n", pin);
>
> Well, this sounds to be more problem-specific rather than
> generic "something unexpected in the switch statement".
>
>> The commit log mentions nothing about that.
>
> It seems I have to write more detailed commit message.
> Should I resend?
We prefer one logical change per patch, so it's better to remove all the
pr_err() conversions and resend as v3. And let's just drop the pr_err()
conversions, rtlwifi is an old driver and we want to keep changes to
that driver to the minimum. rtlw8xxxu, rtw88 and rtw89 are the active
Realtek drivers.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-06-14 5:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 10:07 [PATCH] wifi: rtlwifi: remove misused flag from HAL data Dmitry Antipov
2023-06-08 0:48 ` Ping-Ke Shih
2023-06-08 9:50 ` [PATCH 1/4] [v2] wifi: rtlwifi: remove unused timer and related code Dmitry Antipov
2023-06-08 9:50 ` [PATCH 2/4] [v2] wifi: rtlwifi: remove unused dualmac control leftovers Dmitry Antipov
2023-06-13 1:30 ` Ping-Ke Shih
2023-06-08 9:50 ` [PATCH 3/4] [v2] wifi: rtlwifi: remove misused flag from HAL data Dmitry Antipov
2023-06-13 1:32 ` Ping-Ke Shih
2023-06-08 9:50 ` [PATCH 4/4] [v2] wifi: rtlwifi: simplify LED management Dmitry Antipov
2023-06-13 1:41 ` Ping-Ke Shih
2023-06-13 8:31 ` Kalle Valo
2023-06-13 8:36 ` Dmitry Antipov
2023-06-14 5:21 ` Kalle Valo [this message]
2023-06-15 8:49 ` Dmitry Antipov
2023-06-16 9:54 ` Kalle Valo
2023-06-16 10:20 ` Dmitry Antipov
2023-06-16 16:06 ` Larry Finger
2023-08-01 9:31 ` MAINTAINERS: rtl8187 wireless driver Kalle Valo
2023-08-01 17:04 ` Larry Finger
2023-08-01 17:19 ` Kalle Valo
[not found] ` <2131579919.392146.1690979184620@mail.yahoo.com>
2023-08-02 14:38 ` Kalle Valo
2023-08-02 22:48 ` Hin-Tak Leung
2023-06-14 6:18 ` [PATCH 1/2] [v3] wifi: rtlwifi: simplify LED management Dmitry Antipov
2023-06-14 6:18 ` [PATCH 2/2] [v3] wifi: rtlwifi: cleanup USB interface Dmitry Antipov
2023-06-14 7:08 ` Ping-Ke Shih
2023-06-14 8:05 ` Dmitry Antipov
2023-06-14 7:11 ` [PATCH 1/2] [v3] wifi: rtlwifi: simplify LED management Ping-Ke Shih
2023-06-21 18:31 ` Kalle Valo
2023-06-13 1:29 ` [PATCH 1/4] [v2] wifi: rtlwifi: remove unused timer and related code Ping-Ke Shih
2023-06-08 16:03 ` [PATCH] wifi: rtlwifi: remove misused flag from HAL data Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6rad3fp.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).