From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v9 3/4] ath10k: add htt TX bundle for sdio
Date: Tue, 14 Apr 2020 11:10:00 +0300 [thread overview]
Message-ID: <87h7xmtrmv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <185d31c2e6f8792beb240f2c74d26463@codeaurora.org> (Wen Gong's message of "Thu, 09 Apr 2020 23:40:41 +0800")
Wen Gong <wgong@codeaurora.org> writes:
> On 2020-04-09 22:53, Kalle Valo wrote:
>> Wen Gong <wgong@codeaurora.org> writes:
>>
>>> + ar->workqueue_tx_complete =
>>> + create_singlethread_workqueue("ath10k_tx_complete_wq");
>>> + if (!ar->workqueue_tx_complete)
>>> + goto err_free_aux_wq;
>>
>> We already have three threads:
>>
>> ath/ath10k/core.c: ar->workqueue =
>> create_singlethread_workqueue("ath10k_wq");
>> ath/ath10k/core.c: ar->workqueue_aux =
>> create_singlethread_workqueue("ath10k_aux_wq");
>> ath/ath10k/sdio.c: ar_sdio->workqueue =
>> create_singlethread_workqueue("ath10k_sdio_wq");
>>
>> Do we really need a fourth one? For example, why can't we use
>> ar->workqueue_aux?
>
> For tcp test, it has 4 thread work meanwhile:
> tx_bundle_skbs(ar->workqueue),
> rx_indication(ar->workqueue_aux),
> sdio_async_tx_request(ar_sdio->workqueue),
> tx_bundle_complete(ar->workqueue_tx_complete)
>
> It has 4+ cpu/core in system, if reduced to 3 threads, then tcp
> throughput will drop. only when it only has 1/2/3 cpu/core in system,
> then reduced to 3 threads will not drop.
How much does it drop? Please add the justification (with numbers) for
the new thread to the commit log, so that the reason is properly
documented.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-14 8:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 8:04 [PATCH v9 0/4] ath10k: improve throughout of TX of sdio Wen Gong
2020-02-12 8:04 ` [PATCH v9 1/4] ath10k: disable TX complete indication of htt for sdio Wen Gong
2020-04-07 5:44 ` Kalle Valo
[not found] ` <20200407054431.6B2A0C433BA@smtp.codeaurora.org>
2020-04-07 6:04 ` Wen Gong
2020-04-07 6:08 ` Kalle Valo
2020-04-09 14:52 ` Kalle Valo
2020-02-12 8:04 ` [PATCH v9 2/4] ath10k: change ATH10K_SDIO_BUS_REQUEST_MAX_NUM from 64 to 1024 Wen Gong
2020-02-12 8:04 ` [PATCH v9 3/4] ath10k: add htt TX bundle for sdio Wen Gong
2020-04-09 14:53 ` Kalle Valo
2020-04-09 15:40 ` Wen Gong
2020-04-14 8:10 ` Kalle Valo [this message]
2020-04-16 12:27 ` Kalle Valo
2020-04-18 14:02 ` Wen Gong
2020-04-21 11:56 ` Kalle Valo
2020-04-09 15:05 ` Kalle Valo
2020-04-09 15:29 ` Wen Gong
2020-04-09 15:42 ` Kalle Valo
2020-04-09 15:55 ` Wen Gong
2020-02-12 8:04 ` [PATCH v9 4/4] ath10k: enable alt data of TX path " Wen Gong
2020-04-10 6:21 ` [PATCH v9 0/4] ath10k: improve throughout of TX of sdio Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7xmtrmv.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).