From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, pkshih@realtek.com
Subject: Re: [PATCH] rtlwifi: rtl_pci: Fix errors when CONFIG_RTLWIFI_DEBUG is not set
Date: Sat, 21 Sep 2019 10:44:31 +0300 [thread overview]
Message-ID: <87h856ayao.fsf@codeaurora.org> (raw)
In-Reply-To: <20190920022533.23085-1-Larry.Finger@lwfinger.net> (Larry Finger's message of "Thu, 19 Sep 2019 21:25:33 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> When rtlwifi debugging is disabled, missing globals occur due to the
> attempt execution of code that is never generated.
Do you have the exact error message? I don't know why this is failing.
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/net/wireless/realtek/rtlwifi/pci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wireless/realtek/rtlwifi/pci.c
> index 6087ec7a90a6..2f8aad28f1c0 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/pci.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
> @@ -2298,8 +2298,10 @@ int rtl_pci_probe(struct pci_dev *pdev,
> }
> rtlpriv->mac80211.mac80211_registered = 1;
>
> +#ifdef CONFIG_RTLWIFI_DEBUG
> /* add for debug */
> rtl_debug_add_one(hw);
> +#endif
>
> /*init rfkill */
> rtl_init_rfkill(hw); /* Init PCI sw */
> @@ -2349,8 +2351,10 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
> wait_for_completion(&rtlpriv->firmware_loading_complete);
> clear_bit(RTL_STATUS_INTERFACE_START, &rtlpriv->status);
>
> +#ifdef CONFIG_RTLWIFI_DEBUG
> /* remove form debug */
> rtl_debug_remove_one(hw);
> +#endif
Then I checked debug.h I see that it's supposed to be handled already:
#ifdef CONFIG_RTLWIFI_DEBUG
void rtl_debug_add_one(struct ieee80211_hw *hw);
void rtl_debug_remove_one(struct ieee80211_hw *hw);
void rtl_debugfs_add_topdir(void);
void rtl_debugfs_remove_topdir(void);
#else
#define rtl_debug_add_one(hw)
#define rtl_debug_remove_one(hw)
#define rtl_debugfs_add_topdir()
#define rtl_debugfs_remove_topdir()
#endif
But the else part looks weird, I'm used to using inline functions
instead of defines:
static inline void rtl_debug_add_one(struct ieee80211_hw *hw) {}
static inline void rtl_debug_remove_one(struct ieee80211_hw *hw) {}
static inline void rtl_debugfs_add_topdir(void) {}
static inline void rtl_debugfs_remove_topdir(void) {}
Inline functions also make it possible for the compiler to check the
types are correct.
--
Kalle Valo
prev parent reply other threads:[~2019-09-21 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 2:25 [PATCH] rtlwifi: rtl_pci: Fix errors when CONFIG_RTLWIFI_DEBUG is not set Larry Finger
2019-09-20 6:17 ` Kalle Valo
2019-09-21 7:44 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h856ayao.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).