From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: linux-wireless@vger.kernel.org,
Sebastian Gottschall <s.gottschall@newmedia-net.de>,
ath10k@lists.infradead.org
Subject: Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets
Date: Fri, 06 Apr 2018 11:07:39 +0300 [thread overview]
Message-ID: <87h8oosqpg.fsf@codeaurora.org> (raw)
In-Reply-To: <de9c007f-26e3-a511-e944-91e90aac7787@dd-wrt.com> (Sebastian Gottschall's message of "Thu, 5 Apr 2018 22:00:43 +0200")
Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
> i have some comments about your check warnings.
> some of them are bogus. for instance they advise to use "unsigned int"
> instead of "unsigned". this might be better, but
> the original kernel header uses "unsigned" as api definition. so i
> decided to use the same declarations here.
Sure, but using "unsigned int" won't create any harm either.
> for the rest like whitespaces i will make a new version and remove them
You missed my comment in my earlier mail that I'll send the next
version. I have already fixed all the warnings so let me submit it. I'll
do also some other changes.
--
Kalle Valo
next prev parent reply other threads:[~2018-04-06 8:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 8:44 [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets s.gottschall
2018-02-27 17:03 ` Steve deRosier
2018-02-27 17:43 ` Sebastian Gottschall
2018-02-27 22:08 ` Rafał Miłecki
2018-02-28 1:49 ` Sebastian Gottschall
2018-03-02 9:03 ` Pavel Machek
2018-03-02 9:22 ` Sebastian Gottschall
2018-03-07 16:22 ` Rafał Miłecki
2018-03-07 17:54 ` Sebastian Gottschall
2018-03-08 9:02 ` Pavel Machek
2018-03-08 12:33 ` Sebastian Gottschall
2018-03-08 14:05 ` Pavel Machek
2018-03-08 14:29 ` Kalle Valo
2018-03-08 14:43 ` Sebastian Gottschall
2018-03-08 14:34 ` Sebastian Gottschall
2018-03-08 15:04 ` Pavel Machek
2018-03-08 15:31 ` Sebastian Gottschall
2018-03-08 15:46 ` Felix Fietkau
2018-03-10 7:44 ` Julian Calaby
2018-03-10 7:56 ` Sebastian Gottschall
2018-03-12 7:53 ` Mathias Kresin
2018-03-12 9:09 ` Sebastian Gottschall
2018-04-05 14:44 ` Kalle Valo
2018-04-05 18:01 ` Sebastian Gottschall
2018-04-05 20:00 ` Sebastian Gottschall
2018-04-06 8:07 ` Kalle Valo [this message]
2018-04-06 8:10 ` Sebastian Gottschall
[not found] ` <1d917688-9f59-39ad-46a6-527d9e3dec03@dd-wrt.com>
2018-04-06 8:09 ` Kalle Valo
2018-04-06 8:11 ` Sebastian Gottschall
2018-04-06 8:25 ` Kalle Valo
[not found] ` <f3617290-34d5-0cca-6442-4a37c06701b1@dd-wrt.com>
2018-04-06 9:17 ` Kalle Valo
2018-04-06 8:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8oosqpg.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.gottschall@dd-wrt.com \
--cc=s.gottschall@newmedia-net.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).