From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [3/3] rtlwifi: Enable debug mask to be set from sysfs
Date: Thu, 19 Jan 2017 10:57:23 +0200 [thread overview]
Message-ID: <87h94vpguk.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <5aefd440-1b6f-1791-d85b-e71464c47620@lwfinger.net> (Larry Finger's message of "Wed, 18 Jan 2017 10:38:01 -0600")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 01/18/2017 08:49 AM, Kalle Valo wrote:
>> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>> The previous commit changes the debug system to use a mask to select
>>> which components are to be debugged. Now, we add the necessary code
>>> to change the mask from sysfs.
>>>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>> Cc: Ping-Ke Shih <pkshih@realtek.com>
>>
>> There's already a generic sysfs interface to change module parameters in
>> /sys/module/<driver>/parameters, drivers should not have a private interface for
>> that.
>
> Kalle,
>
> I was not aware of that part of sysfs. I will respin the patch as well
> as remove the old code that set the debug level.
Good, thanks. I dropped the whole series now and assume that you will
send v2.
--
Kalle Valo
prev parent reply other threads:[~2017-01-19 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 1:07 [PATCH 0/3] rtlwifi: Rework debug system Larry Finger
2017-01-01 1:07 ` [PATCH 1/3] rtlwifi: Redo debugging macros RTPRINT and RT_PRINT_DATA Larry Finger
2017-01-01 1:07 ` [PATCH 2/3] rtlwifi: Convert COMP_XX entries into a proper debugging mask Larry Finger
2017-01-01 1:07 ` [PATCH 3/3] rtlwifi: Enable debug mask to be set from sysfs Larry Finger
2017-01-18 14:49 ` [3/3] " Kalle Valo
2017-01-18 16:38 ` Larry Finger
2017-01-19 8:57 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h94vpguk.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).