From: Kalle Valo <kvalo@codeaurora.org>
To: Prameela Rani Garnepudi <prameela.garnepudi@redpinesignals.com>
Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
linux-wireless@vger.kernel.org, johannes.berg@intel.com,
hofrat@osadl.org, xypron.glpk@gmx.de
Subject: Re: [PATCH 1/5] rsi: Device configuration bootup parameters updated
Date: Mon, 28 Nov 2016 09:21:52 +0200 [thread overview]
Message-ID: <87h96s83xr.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <e2acef96-6d2f-e5ad-aa74-5916ebb7e0bf@redpinesignals.com> (Prameela Rani Garnepudi's message of "Mon, 28 Nov 2016 10:13:43 +0530")
Prameela Rani Garnepudi <prameela.garnepudi@redpinesignals.com> writes:
> On 11/14/2016 05:45 PM, Prameela Rani Garnepudi wrote:
>> Switch clock info values are changed in the firmware for both 20MHZ
>> and 40MHZ modes. Hence these values which are configured through boot
>> parameters request frame are updated. Also three other power save
>> related parameters are added to boot up parameters.
>>
>> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
(Removed over hundred lines of unnecessary quotes, please edit your
quotes.)
> Can you please tell me, what modifications need to be done for this
> patch. I already modified the code as per your previous suggestions.
Like always, please check the patchwork before sending any emails. The
patch in question is here:
https://patchwork.kernel.org/patch/9427401/
It's in state "Changes Requested" which means that one of patches in the
patchset should have some comments. After looking at the other patches I
see my comment in patch 2:
https://patchwork.kernel.org/patch/9427419/
"Based on Documentation/kernel-documentation.rst this doesn't
look to be valid kernel-doc format. But AFAICS you got the
format correct in patch 3.
Also this function uses negative error codes (as preferred),
it's not just -1 on failure. You should fix that in the comment
(similar problems also elsewhere in this patchset)."
--
Kalle Valo
prev parent reply other threads:[~2016-11-28 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 12:15 [PATCH 1/5] rsi: Device configuration bootup parameters updated Prameela Rani Garnepudi
[not found] ` <e2acef96-6d2f-e5ad-aa74-5916ebb7e0bf@redpinesignals.com>
2016-11-28 7:21 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h96s83xr.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=hofrat@osadl.org \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=prameela.garnepudi@redpinesignals.com \
--cc=prameela.j04cs@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox