From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] ath10k: speed up hw recovery
Date: Tue, 21 Oct 2014 11:29:54 +0300 [thread overview]
Message-ID: <87h9yxyge5.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQn9Rc4fLUV8JS5_ZrrckyNz8YPevgmc+FpxtGJ1xhtX2w@mail.gmail.com> (Michal Kazior's message of "Tue, 21 Oct 2014 10:23:31 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 21 October 2014 10:17, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> In some cases hw recovery was taking an absurdly
>>> long time due to ath10k waiting for things that
>>> would never really complete.
>>>
>>> Instead of waiting for inevitable timeouts poke
>>> all completions and wakequeues and check if it's
>>> still worth waiting.
>>>
>>> Reading/writing ar->state requires conf_mutex.
>>> Since waiters might be holding it introduce a new
>>> flag CRASH_FLUSH so it's possible to tell waiters
>>> to abort whatever they were waiting for.
>>>
>>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>>
>> While applying to ath-next-test there was a conflict in core.h. Please
>> check my resolution:
>>
>> https://github.com/kvalo/ath/commit/6cccda0185c7df96f439dc3f87961e81843de3ee
>
> I think it was `enum ath10k_cal_mode {` vs `enum ath10k_scan_state {`
> because my patch was based without your cal patches.
Yeah, that was the reason as I applied the cal file patches just an hour
ago. With the amount of patches going to ath10k these conflicts are
"business as usual", we just need to be careful with resolutions. As
long as everyone use ath.git master branch as the baseline everything
should go pretty smoothly, most of the time :)
--
Kalle Valo
next prev parent reply other threads:[~2014-10-21 8:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 12:22 [PATCH v2 0/3] ath10k: speed up recovery Michal Kazior
2014-10-20 12:22 ` [PATCH v2 1/3] ath10k: fix possible bmi crash Michal Kazior
2014-10-20 12:22 ` [PATCH v2 2/3] ath10k: expose hw restart via debugfs Michal Kazior
2014-10-20 12:22 ` [PATCH v2 3/3] ath10k: speed up hw recovery Michal Kazior
2014-10-21 8:17 ` Kalle Valo
2014-10-21 8:23 ` Michal Kazior
2014-10-21 8:29 ` Kalle Valo [this message]
2014-10-23 13:20 ` [PATCH v2 0/3] ath10k: speed up recovery Michal Kazior
2014-10-23 13:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9yxyge5.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).