linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	a.young.jason@gmail.com
Subject: Re: [PATCH PATCH v6 1/7] mac80211: add U-APSD client support
Date: Tue, 12 Jan 2010 13:14:18 +0200	[thread overview]
Message-ID: <87hbqrtw1h.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1263292276.3583.15.camel@johannes.local> (Johannes Berg's message of "Tue\, 12 Jan 2010 11\:31\:16 +0100")

Johannes Berg <johannes@sipsolutions.net> writes:

> On Tue, 2010-01-12 at 10:42 +0200, Kalle Valo wrote:
>
>> + *
>> + * @IEEE80211_HW_SUPPORTS_UAPSD:
>> + *	Hardware supports Unscheduled Automatic Power Save Delivery
>> + *	(U-APSD) in managed mode. The mode is configured with
>> + *	conf_tx() operation.
>
> I think a little more detail would be good here, for example adding that
> it must support staying awake with just the frame triggering it, and
> that it won't be asked to wake up by mac80211?

Good point. I was planning to improve power save documentation, I do
that in this patchset and I'll also add more documentation about
U-APSD. That should help to understand this more.

> Or will it, actually? We've had that discussion with PS-poll so ...

Yes, HW must stay awake until end of service period. I'll write more
documentation to clear up all this.

-- 
Kalle Valo

  reply	other threads:[~2010-01-12 11:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-12  8:42 [PATCH PATCH v6 0/7] mac80211 client U-APSD support Kalle Valo
2010-01-12  8:42 ` [PATCH PATCH v6 1/7] mac80211: add U-APSD client support Kalle Valo
2010-01-12 10:31   ` Johannes Berg
2010-01-12 11:14     ` Kalle Valo [this message]
2010-01-13 14:50       ` Kalle Valo
2010-01-12  8:42 ` [PATCH PATCH v6 2/7] mac80211: add debugfs interface for U-APSD queue configuration Kalle Valo
2010-01-12  8:42 ` [PATCH PATCH v6 3/7] mac80211: create tx handler for dynamic ps Kalle Valo
2010-01-12  8:42 ` [PATCH PATCH v6 4/7] mac80211: check uapsd state for dynamic power save Kalle Valo
2010-01-12  8:43 ` [PATCH PATCH v6 5/7] ieee80211: add struct ieee80211_hdr_qos Kalle Valo
2010-01-12  8:43 ` [PATCH PATCH v6 6/7] wl1251: create qos null data template Kalle Valo
2010-01-12  8:43 ` [PATCH PATCH v6 7/7] wl1251: add U-APSD support Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbqrtw1h.fsf@purkki.valot.fi \
    --to=kalle.valo@iki.fi \
    --cc=a.young.jason@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).