p54: power save disable patch twice

p54: power save disable patch twice

[Kalle Valo]

Hi John,

I noticed that latest wireless-testing had this patch twice:

    p54: deactivate broken powersave function
    
    This patch deactivates powersave in station mode.
    
    It does not work correctly yet, so the code does more harm than
    good.
    
    Reported-by: Johannes Berg <johannes@sipsolutions.net>
    Signed-off-by: Christian Lamparter <chunkeey@web.de>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

The first patch removes IEEE80211_HW_SUPPORTS_PS and
IEEE80211_HW_PS_NULLFUNC_STACK, and the second patch removes only
IEEE80211_HW_BEACON_FILTER. I assume that the idea was to remove
everything in one go.

-- 
Kalle Valo

Re: p54: power save disable patch twice

[John W. Linville]

On Tue, Apr 21, 2009 at 08:36:50AM +0300, Kalle Valo wrote:
> Hi John,
> 
> I noticed that latest wireless-testing had this patch twice:
> 
>     p54: deactivate broken powersave function
>     
>     This patch deactivates powersave in station mode.
>     
>     It does not work correctly yet, so the code does more harm than
>     good.
>     
>     Reported-by: Johannes Berg <johannes@sipsolutions.net>
>     Signed-off-by: Christian Lamparter <chunkeey@web.de>
>     Signed-off-by: John W. Linville <linville@tuxdriver.com>
> 
> The first patch removes IEEE80211_HW_SUPPORTS_PS and
> IEEE80211_HW_PS_NULLFUNC_STACK, and the second patch removes only
> IEEE80211_HW_BEACON_FILTER. I assume that the idea was to remove
> everything in one go.

The original patch was against the master branch and did all of
them together.  But I sent it to 2.6.30, which didn't ahve the
beacon filter part.  So I applied it in two parts (more or less).
I probably should alter the commit message for the second part.

Thanks for the reminder!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.