From: Kalle Valo <kalle.valo@iki.fi>
To: "Bob Copeland" <me@bobcopeland.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
linville@tuxdriver.com
Subject: Re: drivers returning wrong results from their _tx op
Date: Fri, 09 Jan 2009 18:17:41 +0200 [thread overview]
Message-ID: <87hc48tpwa.fsf@litku.valot.fi> (raw)
In-Reply-To: <20090109153716.M19288@bobcopeland.com> (Bob Copeland's message of "Fri\, 9 Jan 2009 10\:44\:22 -0500")
"Bob Copeland" <me@bobcopeland.com> writes:
> On Fri, 09 Jan 2009 10:13:56 +0200, Kalle Valo wrote
>> > @@ -1170,6 +1170,7 @@ enum ieee80211_ampdu_mlme_action {
>> > * configuration in the TX control data. This handler should,
>> > * preferably, never fail and stop queues appropriately, more
>> > * importantly, however, it must never fail for A-MPDU-queues.
>> > + * Returns NETDEV_TX_OK, or NETDEV_TX_BUSY if it fails.
>> > * Must be implemented and atomic.
>>
>> Based on discussion from netdev I have understood that NETDEV_TX_BUSY
>> is not recommended, it's better to stop the queue already earlier,
>> drop the frame or store the skb somewhere else temporarily. Johannes,
>> have I understood this correctly?
>>
>> It would be nice to have this documented here.
>
> Read the sentence before the added line :-)
I read it. Adding "or NETDEV_TX_BUSY if it fails" is just confusing,
better to state that it just should not fail.
--
Kalle Valo
next prev parent reply other threads:[~2009-01-09 16:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 22:07 drivers returning wrong results from their _tx op Johannes Berg
2009-01-05 22:24 ` Bob Copeland
2009-01-06 13:00 ` Johannes Berg
2009-01-09 2:23 ` Bob Copeland
2009-01-09 8:13 ` Kalle Valo
2009-01-09 10:06 ` Johannes Berg
2009-01-09 15:44 ` Bob Copeland
2009-01-09 16:17 ` Kalle Valo [this message]
2009-01-09 18:27 ` Bob Copeland
2009-01-09 18:47 ` Kalle Valo
2009-01-11 3:12 ` Bob Copeland
2009-01-11 6:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hc48tpwa.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).