Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Tomas Tonhauser <t.tonhauser@pobox.sk>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
	linux-kernel@vger.kernel.org,
	Tomas Tonhauser <t.tonhauser@pobox.sk>
Subject: Re: [PATCH v2 0/2] wifi: ath9k: fix loss of non-aggregate frames
Date: Tue, 17 Nov 2026 10:09:58 +0100	[thread overview]
Message-ID: <87ik1vu8m1.fsf@toke.dk> (raw)
In-Reply-To: <20261028171652.1125692-1-t.tonhauser@pobox.sk>

Tomas Tonhauser <t.tonhauser@pobox.sk> writes:

> Non-aggregate frames (stations without an A-MPDU session, e.g.
> non-WMM ESP8266 clients) are lost on ath9k in two ways:
>
>  1. The hardware filters them (ATH9K_TXERR_FILT) while the station
>     is awake, and mac80211 retries a filtered frame only once.
>     Patch 1 sets CLRDMASK on every non-aggregate frame.
>
>  2. Frames that exhaust the hardware retry chain are dropped, as
>     there is no software retry for non-aggregate frames. Patch 2
>     re-queues failed and filtered frames on tid->retry_q, as the
>     aggregate path does.
>
> Toke, I know you were not keen on clearing the filter
> unconditionally, so I first tested your suggestion (patch 2) alone.
> On a weak link it did much worse than patch 1 alone, and the two
> together did best. If you would prefer patch 1 limited, e.g. to
> stations that are not sleeping, I can rework it.

So an alternative solution to what appears to be the same problem your
patch 1 is solving appeared:

https://lore.kernel.org/r/20261110170459.31857-1-dominikengelhardt@ymail.com

Could you please check if this approach works in your tests (with or
without patch 2)?

Thanks!

-Toke

      parent reply	other threads:[~2026-11-17  9:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 17:16 [PATCH v2 0/2] wifi: ath9k: fix loss of non-aggregate frames Tomas Tonhauser
2026-10-28 17:16 ` [PATCH v2 1/2] wifi: ath9k: clear destination mask for " Tomas Tonhauser
2026-10-28 17:16 ` [PATCH v2 2/2] wifi: ath9k: retry failed non-aggregate frames in software Tomas Tonhauser
2026-11-17  9:09 ` Toke Høiland-Jørgensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ik1vu8m1.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=t.tonhauser@pobox.sk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox