From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 196922765D7; Thu, 16 Apr 2026 19:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.145.95.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776366964; cv=none; b=nWQlwxWU+TVZmqPzZJ1oBZt4WF/75QQa7L7T10bVPAokfEgMmmSOsZsJBzoSN1iu7CnZHl3Zn+dXw9Iz47GkzNWJh/8V92+IM+Y576rtsqFSxtCEKt5NwmmWkZwjsk3fKHzzWHz/IDkLQAlK9z9DdGdv9W/GLpLasDUTu1+HCaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776366964; c=relaxed/simple; bh=SLAVdoNO18AUUku2BU6T3beDzbXwGJYaFeE1g2rm2ek=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=pb3cHB9rqMVpBRocvS32MizcJtencxj3rYxe7Q1n3GQVpYTMuy+06t6C0iueza/x5rutRwSnLzLRTnqLCb0ViyRaiWSU8hVQ6s4PhYkdDhQ4AEZhNPSNH5E9WjsnZ8JUqgihifB05/Ya9qoH6XjGPGZ+x1LE6g7qmJfsipgxZhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=toke.dk; spf=pass smtp.mailfrom=toke.dk; arc=none smtp.client-ip=45.145.95.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=toke.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=toke.dk From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Authentication-Results: mail.toke.dk; dkim=none To: Tristan Madani Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] wifi: ath9k: fix OOB access from firmware tx status queue ID In-Reply-To: <20260415222343.1540564-1-tristmd@gmail.com> References: <20260415222343.1540564-1-tristmd@gmail.com> Date: Thu, 16 Apr 2026 21:15:51 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87ik9qbtso.fsf@toke.dk> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tristan Madani writes: > From: Tristan Madani > > ath_tx_edma_tasklet() accesses sc->tx.txq[ts.qid] where ts.qid is a > 4-bit hardware field (0-15), but the txq array only has > ATH9K_NUM_TX_QUEUES (10) entries. A qid >=3D 10 causes an OOB array > access. > > Add a bounds check on ts.qid before using it as an array index. > > Fixes: fce041beb03f ("ath9k: unify edma and non-edma tx code, improve tx = fifo handling") > Signed-off-by: Tristan Madani Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen