From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AAC8C0015E for ; Thu, 27 Jul 2023 06:10:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232695AbjG0GK2 (ORCPT ); Thu, 27 Jul 2023 02:10:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232688AbjG0GK0 (ORCPT ); Thu, 27 Jul 2023 02:10:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7830F1731 for ; Wed, 26 Jul 2023 23:10:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E4EF61D30 for ; Thu, 27 Jul 2023 06:10:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AFF2C433C7; Thu, 27 Jul 2023 06:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690438224; bh=b1xzARFcfbsh47td8lDof2znYm6SZgwcnpC+n8lHdr8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ML29VomnBsCtFJ0bDngtcOR1CdC/PqR8FgQWVhDSdlJn+bx+MMQNeNFcYT5nmSfSQ rlFRr0WnZncYjN+cWWhD7dUxTUoQyPknD/QB3w8QubKKm4bczP/+Ery4G2/+pAy3yY vvh2ZKZf8wR9es8TaSMCHd45LN//knEHsjk4ofov7eBWeT56GQwYsAj3P3IsM+F6hX Zy/QljUo+43NcYMPW4LUS5Pv2wLz3n/VI/6D4q9qu6mmRzN573FkJLz0NkEPSXLb8B ofADyhWzyiiFOfrlejxj6sWfxpfvJBuXQRgrOmJNAvZZbgKxrLaaptWrck2RJ9pngb 8QpzE0h5bVR5g== From: Kalle Valo To: Brian Norris Cc: Polaris Pi , matthewmwang@chromium.org, kuba@kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v7] wifi: mwifiex: Fix OOB and integer underflow when rx packets References: <20230723070741.1544662-1-pinkperfect2021@gmail.com> Date: Thu, 27 Jul 2023 09:10:20 +0300 In-Reply-To: (Brian Norris's message of "Wed, 26 Jul 2023 14:23:42 -0700") Message-ID: <87ila528c3.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Brian Norris writes: > On Sun, Jul 23, 2023 at 07:07:41AM +0000, Polaris Pi wrote: >> Make sure mwifiex_process_mgmt_packet, >> mwifiex_process_sta_rx_packet and mwifiex_process_uap_rx_packet, >> mwifiex_uap_queue_bridged_pkt and mwifiex_process_rx_packet >> not out-of-bounds access the skb->data buffer. >> >> Fixes: 2dbaf751b1de ("mwifiex: report received management frames to cfg80211") >> Signed-off-by: Polaris Pi >> --- >> V5: Follow chromeos comments: preserve the original flow of mwifiex_process_uap_rx_packet >> V6: Simplify check in mwifiex_process_uap_rx_packet >> V7: Fix drop packets issue when auotest V6, now pass manual and auto tests > > "auto tests" isn't clear to anyone not familiar with Chromium stuff. > It'd be courteous to at least make an attempt to describe what this > means (even just, "ChromeOS WiFi test suite" or something). For the > record, I believe that's approximately this? > > https://chromium.googlesource.com/chromiumos/third_party/autotest/+/HEAD/docs/wificell.md > > Anyway, I think the patch contents look good: > > Reviewed-by: Brian Norris I'm nitpicking but now that you (Brian) are a maintainer I would prefer that you use Acked-by instead of Reviewed-by. Patchwork shows the statistics (A/R/T in the web ui) and then it's easy for me to see that the patch is ready to be applied. This is for the future, no need to change anything here. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches