From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F57EECAAD5 for ; Thu, 8 Sep 2022 09:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231371AbiIHJSy (ORCPT ); Thu, 8 Sep 2022 05:18:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbiIHJSs (ORCPT ); Thu, 8 Sep 2022 05:18:48 -0400 Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6290DD293A for ; Thu, 8 Sep 2022 02:18:45 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1662628723; bh=idX9htAOlhMB3K5vdodzlR2ovFnvxgJtSye+uG5Dlog=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SCw3997poR4wzziJwcAXbqCHPS9W6NIX7grDPj6pthtwKvcRoOA9dOV3vEbaEvzsY bxA46ma9c+yZBI+cXWeKGPE3IQBlOyFBjJUlkaI6X7rx3NDf38mwS7Oj+LaG233rnf nyRw7J2bkbcJkJAKlmW9TBvav8oWRLVl5ePbXNpGD8GWRWLImZqamTZhST72MZwM+m e21aE1AsyYdHUGuWtr/FNNSRQ9aiDdihmQ+PpLbMgWs+qZnms2Z9hV+vTSBA68AXSR 0d33tYLfo2Kd/GkRjvoGAlbourxxg3d0QjFZuRKBeUy75QVnixAtw4fnhmgurVsPiK s0Q65dZ8R6K6A== To: Emmanuel Grumbach Cc: Gregory Greenman , Emmanuel Grumbach , Kalle Valo , Ayala Beker , linux-wireless@vger.kernel.org, Golan Ben Ami Subject: Re: [PATCH] iwlwifi: Mark IWLMEI as broken In-Reply-To: References: <20220907134450.1183045-1-toke@toke.dk> Date: Thu, 08 Sep 2022 11:18:43 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87illyxlzg.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Emmanuel Grumbach writes: > Hi, > > > On Wed, Sep 7, 2022 at 5:02 PM Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> >> From: Toke H=C3=B8iland-J=C3=B8rgensen >> >> The iwlmei driver breaks iwlwifi when returning from suspend; the bug >> report[0] has been open for four months now, and now fix seems to be >> forthcoming. Since just disabling the iwlmei driver works as a workaroun= d, >> let's mark the config option as broken until it can be fixed properly. >> >> [0] https://bugzilla.kernel.org/show_bug.cgi?id=3D215937 >> >> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation = with CSME") >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > > I am not very proud of this, to say the least, but unfortunately, > despite Toke's patience and > his willingness to provide logs and all, I couldn't find the time to fix = this. Well, thanks for your efforts anyway :) > We had tested against NetworkManager wpa_s, but not against iwd. > From the start, we thought distro wouldn't enable this and this is why > we disabled iwlmei by default. > This driver is meant to be used by specific groups that need this and > they'll know how to enable this > driver even if it is marked as BROKEN. > > This is why, with a heavy heart: > Acked-by: Emmanuel Grumbach Thanks! > I'd also suggest to CC this to stable 5.17+ I expect the Fixes tag will be enough to get this pulled into stable, but I'll try to keep an eye on it and submit it there manually if not... > Thanks Toke and Sorry! You're welcome :) -Toke