From: Kalle Valo <kvalo@codeaurora.org>
To: Giuseppe Marco Randazzo <gmrandazzo@gmail.com>
Cc: chunkeey@googlemail.com, davem@davemloft.net,
linux-wireless@vger.kernel.org
Subject: Re: PATCH p54usb.c to support AirVasT USB wireless adapter
Date: Mon, 06 Apr 2020 11:02:03 +0300 [thread overview]
Message-ID: <87imidf3es.fsf@codeaurora.org> (raw)
In-Reply-To: <CADT+tpPuQo7DZ9sSZCMiwUe8EVU4wZjBMhnVn=AHCUkBXnpqKg@mail.gmail.com> (Giuseppe Marco Randazzo's message of "Sun, 5 Apr 2020 22:42:06 +0200")
Hi Giuseppe,
Giuseppe Marco Randazzo <gmrandazzo@gmail.com> writes:
> Dear p54 maintainers,
>
> the following patch allows to use the AirVasT USB wireless devices
> 124a:4026 using the ISL3886 usb firmware. Without this modification,
> the wiki adapter is not either recognized.
>
> Best regards,
> Giuseppe Marco "zeld" Randazzo
>
> ---
> /home/marco/LinuxKernel/linux/drivers/net/wireless/intersil/p54/p54usb.c.orig
> 2020-04-05 21:28:08.247905535 +0200
> +++
> /home/marco/LinuxKernel/linux/drivers/net/wireless/intersil/p54/p54usb.c
> 2020-04-05 21:45:31.677747811 +0200
> @@ -98,6 +98,7 @@ static const struct usb_device_id p54u_t
> {USB_DEVICE(0x0cde, 0x0015)}, /* Zcomax XG-705A */
> {USB_DEVICE(0x0d8e, 0x3762)}, /* DLink DWL-G120 Cohiba */
> {USB_DEVICE(0x124a, 0x4025)}, /* IOGear GWU513 (GW3887IK chip) */
> + {USB_DEVICE(0x124a, 0x4026)}, /* AirVasT */
> {USB_DEVICE(0x1260, 0xee22)}, /* SMC 2862W-G version 2 */
> {USB_DEVICE(0x13b1, 0x000a)}, /* Linksys WUSB54G ver 2 */
> {USB_DEVICE(0x13B1, 0x000C)}, /* Linksys WUSB54AG */
>
> Signed-off-by: Giuseppe Marco "zeld" Randazzo <gmrandazzo@gmail.com>
Your patch has multiple issues, starting with use of HTML. I see that
Christian submitted your patch in correct format so this patch is now
properly in queue:
https://patchwork.kernel.org/patch/11474885/
But for future patches please first read the documentation from the link
below, it's important that the patches are submitted in correct format.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
parent reply other threads:[~2020-04-06 8:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CADT+tpPuQo7DZ9sSZCMiwUe8EVU4wZjBMhnVn=AHCUkBXnpqKg@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imidf3es.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=chunkeey@googlemail.com \
--cc=davem@davemloft.net \
--cc=gmrandazzo@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).