From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org, linuxwifi@intel.com,
david.e.box@intel.com, joe.konno@intel.com
Subject: Re: pull-request: iwlwifi-next 2019-11-13
Date: Wed, 13 Nov 2019 15:31:56 +0200 [thread overview]
Message-ID: <87imnnx5pv.fsf@codeaurora.org> (raw)
In-Reply-To: <3bb7b4be7b9011f4f043b84f26657260f7c4ab02.camel@coelho.fi> (Luca Coelho's message of "Wed, 13 Nov 2019 11:30:30 +0200")
Luca Coelho <luca@coelho.fi> writes:
> Here's the second batch of patches intended for v5.4. This includes the
> last patchset 2 patchsets I sent. Usual development work. More
> details about the contents in the tag description.
>
> I pushed these patches to my pending branch when I sent them out and
> kbuildbot reported success.
>
> Please let me know if there are any issues.
I did a test pull and it fails to build for me, error below. I had
'CONFIG_ACPI=y' in the config, in case that makes a difference.
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:683:15: warning: 'struct iwl_mvm_sar_profile' declared inside parameter list will not be visible outside of this definition or declaration
struct iwl_mvm_sar_profile *profile,
^~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_set_profile':
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:688:9: error: dereferencing pointer to incomplete type 'struct iwl_mvm_sar_profile'
profile->enabled = enabled;
^~
drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_get_wrds_table':
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:732:48: error: 'struct iwl_mvm' has no member named 'sar_profiles'
ret = iwl_mvm_sar_set_profile(mvm, table, &mvm->sar_profiles[0],
^~
drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_get_ewrd_table':
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:786:16: error: 'struct iwl_mvm' has no member named 'sar_profiles'
&mvm->sar_profiles[i + 1],
^~
drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_get_wgds_table':
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:822:5: error: 'struct iwl_mvm' has no member named 'geo_rev'
mvm->geo_rev = tbl_rev;
^~
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:834:7: error: 'struct iwl_mvm' has no member named 'geo_profiles'
mvm->geo_profiles[i].values[j] = entry->integer.value;
^~
At top level:
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:800:12: warning: 'iwl_mvm_sar_get_wgds_table' defined but not used [-Wunused-function]
static int iwl_mvm_sar_get_wgds_table(struct iwl_mvm *mvm)
^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:739:12: warning: 'iwl_mvm_sar_get_ewrd_table' defined but not used [-Wunused-function]
static int iwl_mvm_sar_get_ewrd_table(struct iwl_mvm *mvm)
^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:701:12: warning: 'iwl_mvm_sar_get_wrds_table' defined but not used [-Wunused-function]
static int iwl_mvm_sar_get_wrds_table(struct iwl_mvm *mvm)
^~~~~~~~~~~~~~~~~~~~~~~~~~
scripts/Makefile.build:265: recipe for target 'drivers/net/wireless/intel/iwlwifi/mvm/fw.o' failed
--
Kalle Valo
next prev parent reply other threads:[~2019-11-13 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 9:30 pull-request: iwlwifi-next 2019-11-13 Luca Coelho
2019-11-13 13:31 ` Kalle Valo [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-20 10:40 Luca Coelho
2019-11-20 18:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imnnx5pv.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=david.e.box@intel.com \
--cc=joe.konno@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).