* [PATCH 08/16] wireless: Replace spin_is_locked() with lockdep [not found] <20181003053902.6910-1-ldr709@gmail.com> @ 2018-10-03 5:38 ` Lance Roy 2018-10-03 9:06 ` Kalle Valo 2018-10-05 8:35 ` [PATCH 08/16] zd1211rw: " Kalle Valo 0 siblings, 2 replies; 5+ messages in thread From: Lance Roy @ 2018-10-03 5:38 UTC (permalink / raw) To: linux-kernel Cc: Paul E. McKenney, Lance Roy, Daniel Drake, Ulrich Kunitz, Kalle Valo, David S. Miller, linux-wireless, netdev lockdep_assert_held() is better suited to checking locking requirements, since it won't get confused when someone else holds the lock. This is also a step towards possibly removing spin_is_locked(). Signed-off-by: Lance Roy <ldr709@gmail.com> Cc: Daniel Drake <dsd@gentoo.org> Cc: Ulrich Kunitz <kune@deine-taler.de> Cc: Kalle Valo <kvalo@codeaurora.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: <linux-wireless@vger.kernel.org> Cc: <netdev@vger.kernel.org> --- drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c index 1f6d9f357e57..9ccd780695f0 100644 --- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c +++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c @@ -235,7 +235,7 @@ void zd_mac_clear(struct zd_mac *mac) { flush_workqueue(zd_workqueue); zd_chip_clear(&mac->chip); - ZD_ASSERT(!spin_is_locked(&mac->lock)); + lockdep_assert_held(&mac->lock); ZD_MEMCLEAR(mac, sizeof(struct zd_mac)); } -- 2.19.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 08/16] wireless: Replace spin_is_locked() with lockdep 2018-10-03 5:38 ` [PATCH 08/16] wireless: Replace spin_is_locked() with lockdep Lance Roy @ 2018-10-03 9:06 ` Kalle Valo 2018-10-04 6:57 ` Lance Roy 2018-10-05 8:35 ` [PATCH 08/16] zd1211rw: " Kalle Valo 1 sibling, 1 reply; 5+ messages in thread From: Kalle Valo @ 2018-10-03 9:06 UTC (permalink / raw) To: Lance Roy Cc: linux-kernel, Paul E. McKenney, Daniel Drake, Ulrich Kunitz, David S. Miller, linux-wireless, netdev Lance Roy <ldr709@gmail.com> writes: > lockdep_assert_held() is better suited to checking locking requirements, > since it won't get confused when someone else holds the lock. This is > also a step towards possibly removing spin_is_locked(). > > Signed-off-by: Lance Roy <ldr709@gmail.com> > Cc: Daniel Drake <dsd@gentoo.org> > Cc: Ulrich Kunitz <kune@deine-taler.de> > Cc: Kalle Valo <kvalo@codeaurora.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: <linux-wireless@vger.kernel.org> > Cc: <netdev@vger.kernel.org> > --- > drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Should I take this or is it going through some other tree? If it goes to via some other tree: Acked-by: Kalle Valo <kvalo@codeaurora.org> -- Kalle Valo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 08/16] wireless: Replace spin_is_locked() with lockdep 2018-10-03 9:06 ` Kalle Valo @ 2018-10-04 6:57 ` Lance Roy 2018-10-04 10:05 ` Kalle Valo 0 siblings, 1 reply; 5+ messages in thread From: Lance Roy @ 2018-10-04 6:57 UTC (permalink / raw) To: Kalle Valo Cc: linux-kernel, Paul E. McKenney, Daniel Drake, Ulrich Kunitz, David S. Miller, linux-wireless, netdev On Wed, Oct 03, 2018 at 12:06:48PM +0300, Kalle Valo wrote: > Lance Roy <ldr709@gmail.com> writes: > > > lockdep_assert_held() is better suited to checking locking requirements, > > since it won't get confused when someone else holds the lock. This is > > also a step towards possibly removing spin_is_locked(). > > > > Signed-off-by: Lance Roy <ldr709@gmail.com> > > Cc: Daniel Drake <dsd@gentoo.org> > > Cc: Ulrich Kunitz <kune@deine-taler.de> > > Cc: Kalle Valo <kvalo@codeaurora.org> > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: <linux-wireless@vger.kernel.org> > > Cc: <netdev@vger.kernel.org> > > --- > > drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Should I take this or is it going through some other tree? Sure you can take this if you like. If not, Paul McKenney will take it in his tree. Thanks, Lance > If it goes to via some other tree: > > Acked-by: Kalle Valo <kvalo@codeaurora.org> > > -- > Kalle Valo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 08/16] wireless: Replace spin_is_locked() with lockdep 2018-10-04 6:57 ` Lance Roy @ 2018-10-04 10:05 ` Kalle Valo 0 siblings, 0 replies; 5+ messages in thread From: Kalle Valo @ 2018-10-04 10:05 UTC (permalink / raw) To: Lance Roy Cc: linux-kernel, Paul E. McKenney, Daniel Drake, Ulrich Kunitz, David S. Miller, linux-wireless, netdev Lance Roy <ldr709@gmail.com> writes: > On Wed, Oct 03, 2018 at 12:06:48PM +0300, Kalle Valo wrote: >> Lance Roy <ldr709@gmail.com> writes: >> >> > lockdep_assert_held() is better suited to checking locking requirements, >> > since it won't get confused when someone else holds the lock. This is >> > also a step towards possibly removing spin_is_locked(). >> > >> > Signed-off-by: Lance Roy <ldr709@gmail.com> >> > Cc: Daniel Drake <dsd@gentoo.org> >> > Cc: Ulrich Kunitz <kune@deine-taler.de> >> > Cc: Kalle Valo <kvalo@codeaurora.org> >> > Cc: "David S. Miller" <davem@davemloft.net> >> > Cc: <linux-wireless@vger.kernel.org> >> > Cc: <netdev@vger.kernel.org> >> > --- >> > drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Should I take this or is it going through some other tree? > > Sure you can take this if you like. If not, Paul McKenney will take it in his > tree. Ok, then I'll take this to wireless-drivers-next. And I'll change the title prefix to "zd1211rw: ". -- Kalle Valo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 08/16] zd1211rw: Replace spin_is_locked() with lockdep 2018-10-03 5:38 ` [PATCH 08/16] wireless: Replace spin_is_locked() with lockdep Lance Roy 2018-10-03 9:06 ` Kalle Valo @ 2018-10-05 8:35 ` Kalle Valo 1 sibling, 0 replies; 5+ messages in thread From: Kalle Valo @ 2018-10-05 8:35 UTC (permalink / raw) To: Lance Roy Cc: linux-kernel, Paul E. McKenney, Lance Roy, Daniel Drake, Ulrich Kunitz, David S. Miller, linux-wireless, netdev Lance Roy <ldr709@gmail.com> wrote: > lockdep_assert_held() is better suited to checking locking requirements, > since it won't get confused when someone else holds the lock. This is > also a step towards possibly removing spin_is_locked(). > > Signed-off-by: Lance Roy <ldr709@gmail.com> > Cc: Daniel Drake <dsd@gentoo.org> > Cc: Ulrich Kunitz <kune@deine-taler.de> > Cc: Kalle Valo <kvalo@codeaurora.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: <linux-wireless@vger.kernel.org> > Cc: <netdev@vger.kernel.org> Patch applied to wireless-drivers-next.git, thanks. 209e957b467b zd1211rw: Replace spin_is_locked() with lockdep -- https://patchwork.kernel.org/patch/10624325/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-05 8:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181003053902.6910-1-ldr709@gmail.com>
2018-10-03 5:38 ` [PATCH 08/16] wireless: Replace spin_is_locked() with lockdep Lance Roy
2018-10-03 9:06 ` Kalle Valo
2018-10-04 6:57 ` Lance Roy
2018-10-04 10:05 ` Kalle Valo
2018-10-05 8:35 ` [PATCH 08/16] zd1211rw: " Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).