From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tom Psyborg <pozega.tomislav@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Stanislaw Gruszka <sgruszka@redhat.com>,
David Miller <davem@davemloft.net>,
Helmut Schaa <helmut.schaa@googlemail.com>,
Daniel Golle <daniel@makrotopia.org>,
Mathias Kresin <dev@kresin.me>,
Johannes Berg <johannes.berg@intel.com>,
Serge Vasilugin <vasilugin@yandex.ru>,
Roman Yeryomin <roman@advem.lv>,
Networking <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jes Sorensen <jes.sorensen@gmail.com>
Subject: Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors
Date: Fri, 19 May 2017 10:12:36 +0300 [thread overview]
Message-ID: <87inkxwc9n.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAK8P3a3Y7rCvmJo062-5G07HGiT6x2MtvVV=dQAVBK0AiX0U_A@mail.gmail.com> (Arnd Bergmann's message of "Fri, 19 May 2017 08:55:21 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> On Fri, May 19, 2017 at 8:44 AM, Tom Psyborg <pozega.tomislav@gmail.com> wrote:
>> warning: 'rt2800_bbp_read' used but never defined
>> static u8 rt2800_bbp_read(struct rt2x00_dev *rt2x00dev,
>> ^
>> /home/ubuntu/Music/openwrt/build_dir/target-mipsel_24kc_musl-1.1.16/linux-ramips_mt7620/compat-wireless-2016-05-12/drivers/net/wireless/ralink/rt2x00/rt2800lib.h:262:13:
>> warning: 'rt2800_bbp_write' used but never defined
>> static void rt2800_bbp_write(struct rt2x00_dev *rt2x00dev,
>> ^
>> CC [M]
>> /home/ubuntu/Music/openwrt/build_dir/target-mipsel_24kc_musl-1.1.16/linux-ramips_mt7620/compat-wireless-2016-05-12/drivers/net/wireless/ralink/rt2x00/rt2800pci.o
>> In file included from
>> /home/ubuntu/Music/openwrt/build_dir/target-mipsel_24kc_musl-1.1.16/linux-ramips_mt7620/compat-wireless-2016-05-12/drivers/net/wireless/ralink/rt2x00/rt2800pci.c:43:0:
>> /home/ubuntu/Music/openwrt/build_dir/target-mipsel_24kc_musl-1.1.16/linux-ramips_mt7620/compat-wireless-2016-05-12/drivers/net/wireless/ralink/rt2x00/rt2800lib.h:259:11:
>> warning: 'rt2800_bbp_read' declared 'static' but never defined
>> [-Wunused-function]
>> static u8 rt2800_bbp_read(struct rt2x00_dev *rt2x00dev,
>> ^
>
> On which base version did you apply my patches? There may be a conflict
> against patches that are in your tree but not yet in linux-next, as I don't see
> the warning and also see no reference to rt2800_bbp_read in rt2800lib.h
I did a test build with current wireless-drivers-next and I also don't
see any warnings.
--
Kalle Valo
next prev parent reply other threads:[~2017-05-19 7:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 14:46 [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 01/10] rt2x00: change function pointers " Arnd Bergmann
2017-05-24 13:46 ` [v2, " Kalle Valo
2017-05-17 14:46 ` [PATCH v2 02/10] rt2x00: convert rt2800_rfcsr_read return type Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 03/10] rt2x00: convert rt2x00_rf_read " Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 04/10] rt2x00: convert rt2x00mmio_register_read " Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 05/10] rt2x00: convert rt2x00usb_register_read " Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 06/10] rt2x00: convert rt2800_register_read " Arnd Bergmann
2017-05-17 14:46 ` [PATCH v2 07/10] rt2x00: convert rt2*_bbp_read " Arnd Bergmann
2017-05-17 14:47 ` [PATCH v2 08/10] rt2x00: convert rt2x00_eeprom_read " Arnd Bergmann
2017-05-17 14:47 ` [PATCH v2 09/10] rt2x00: convert rt2800_eeprom_read " Arnd Bergmann
2017-05-17 14:47 ` [PATCH v2 10/10] rt2x00: convert rt2x00_desc_read " Arnd Bergmann
2017-05-19 5:18 ` [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors Kalle Valo
2017-05-19 6:50 ` Arnd Bergmann
2017-05-19 7:15 ` Kalle Valo
2017-05-19 7:21 ` Arnd Bergmann
[not found] ` <CAKR_QVJGxWF8+ZGGn08XiOgpYVGSjwQwqJoP10fY_bjfRg-uzw@mail.gmail.com>
2017-05-19 6:55 ` Arnd Bergmann
2017-05-19 7:12 ` Kalle Valo [this message]
[not found] ` <CAKR_QVLf5Yn3En2DD4Pwbc2+EKaO9xGB0qU3MWQrNWNjZkx1CA@mail.gmail.com>
2017-05-19 12:20 ` Arnd Bergmann
2017-05-22 18:03 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inkxwc9n.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dev@kresin.me \
--cc=helmut.schaa@googlemail.com \
--cc=jes.sorensen@gmail.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pozega.tomislav@gmail.com \
--cc=roman@advem.lv \
--cc=sgruszka@redhat.com \
--cc=vasilugin@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).