From: Kalle Valo <kvalo@codeaurora.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Takashi Iwai <tiwai@suse.de>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error
Date: Tue, 07 Mar 2017 16:30:08 +0200 [thread overview]
Message-ID: <87innl88i7.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170227214539.16422-1-hdegoede@redhat.com> (Hans de Goede's message of "Mon, 27 Feb 2017 22:45:36 +0100")
Hans de Goede <hdegoede@redhat.com> writes:
> Using pr_err for things which are not errors is a bad idea. E.g. it
> will cause the plymouth bootsplash screen to drop back to the text
> console so that the user can see the error, which is not what we
> normally want to happen.
>
> Instead add a new brcmf_info macro and use that.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Fix brcm_err typo (should be brcmf_err) in CONFIG_BRCM_TRACING case
Oh, missed that there was v2.
--
Kalle Valo
prev parent reply other threads:[~2017-03-07 14:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 21:45 [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error Hans de Goede
2017-02-27 21:45 ` [PATCH v2 2/4] brcmfmac: p2p and normal ap access are not always possible at the same time Hans de Goede
2017-03-07 10:03 ` Arend Van Spriel
2017-03-08 8:24 ` Hans de Goede
2017-03-08 9:26 ` Arend Van Spriel
2017-03-08 10:15 ` Arend Van Spriel
2017-03-08 11:16 ` Hans de Goede
2017-03-10 8:08 ` Hans de Goede
2017-03-10 9:35 ` Arend Van Spriel
2017-03-16 11:51 ` Hans de Goede
2017-02-27 21:45 ` [PATCH v2 3/4] brcmfmac: Do not complain about country code "00" Hans de Goede
2017-03-07 10:04 ` Arend Van Spriel
2017-02-27 21:45 ` [PATCH v2 4/4] brcmfmac: Handle status == BRCMF_E_STATUS_ABORT in cfg80211_escan_handler Hans de Goede
2017-03-07 10:06 ` Arend Van Spriel
2017-03-07 9:59 ` [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error Arend Van Spriel
2017-03-08 8:23 ` Hans de Goede
2017-03-08 9:28 ` Arend Van Spriel
2017-03-08 9:57 ` Kalle Valo
2017-03-08 10:08 ` Hans de Goede
2017-03-08 10:13 ` Arend Van Spriel
2017-03-08 10:14 ` Kalle Valo
2017-03-07 14:30 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87innl88i7.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox